You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rajeshsegu Pull requests are usually merged during one or two sprint periods tops. We've fallen a little bit behind since the team's been focusing on important core features for the last sprints, but we should pick it up soon. In fact, I'll review this one today ;)
@rajeshsegu Thanks for taking this one! Changes look good!
It seems that a commit from #3687 got leaked to this pull request. I guess you created this branch from master after that commit was already there. You should create separate branches before starting to work on separate issues in order to avoid that. Otherwise, you'd need to hold off any work until your previous requests get merged.
If you plan to work further on #3669, I'd suggest you to try and rebase this branch to remove that commit so that we won't be merging any additional code in here. Otherwise, we may take this one as is and just close #3687, but I'd rather keep things separated.
@jbalsas rebasing and making the changes again should be easy, but if you can accomodate the below option, I would be happy. Next time I will make sure I submit changes using a branch.
"Otherwise, we may take this one as is and just close #3687."
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the createNewItem() method never used "set_text" on successCallback of creating a new file item.