You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@redmunds do you have cycles to review this one? Feel free to reassign if not.
Glenn and I couldn't think of any good reason why we didn't make this a submodule originally, so it seems ok to merge assuming the code changes look good.
@peterflynn I reverted that change to brackets-concat.js (learned a lot about git and rebasing this evening...)
The SHA's are pointing to upgraded versions of each (whatever the latest was when I did the submodule add 9 days ago or so).
RequireJS: v2.1.1 >> v2.1.5
Text: v1.0.8 >> v2.0.5
i18n: v1.0.0 >> v2.0.2
Edit: I added another commit, updating to the latest versions
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include RequireJS as a submodule as well as text.js and i18n.js to keep in sync with the repos and make updates easier.