| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 15 Jul 2025 01:56:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=252.990722,conversation_content-fragment;desc="conversation_content fragment";dur=898.530867,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=515.687528,nginx;desc="NGINX";dur=1.270083,glb;desc="GLB";dur=95.243044
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=4OlLwA7Kj%2BNrLrQilWw3b0zsmPwS6Uv0XUD8Dk%2Bkh8N%2FHh2pJWYYbjaTXMoHLwuXaacbbuvpJZiCTSFON5OHVqEevReoNY4BtVxvmF5otU6TrXUFAUH0VCZozM%2F6jeGbbNy4mxURuLRqRFafYuAFLXCymvTiaMMu6%2BnfwRSECnpDcqYjIEYB8NaRx09zqA0jSQ8TqMeFHEWQHEAlk7GJH7EItqo%2FDONiWJ21p73FewJfTbQM02f8nj%2BHk%2F%2Ba3WdJNUjucZLWIv1mmTz9cKnYdQ%3D%3D--4BvCRABHCWBA6RRg--Piu42p30IhdycW0G1fMLng%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.820197532.1752544586; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 01:56:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 01:56:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A668:16BDF7:359DB:50205:6875B54A
Fix #2641: Input field change to blank after double click F2 to rename the file - few user will encounter by TomMalbran · Pull Request #3299 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix #2641: Input field change to blank after double click F2 to rename the file - few user will encounter #3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Assigned @gruehle |
|
Would it be better to just check |
|
I didn't saw that function before. It should work to fix this too. |
| @@ -1272,6 +1272,11 @@ define(function (require, exports, module) { | |||
| // First make sure the item in the tree is visible - jsTree's rename API doesn't do anything to ensure inline input is visible | |||
| showInTree(entry) | |||
| .done(function (selected) { | |||
| // Don't try to rename again if we are already renaming | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go at the top of the function, before the call to showInTree(). There is no real harm in calling showInTree(), but it is not necessary since the item will be visible if it is being renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
Initial review complete. It works as advertised, but the |
| @@ -1302,6 +1302,11 @@ define(function (require, exports, module) { | |||
| * @param {!Entry} entry FileEntry or DirectoryEntry to rename | |||
| */ | |||
| function renameItemInline(entry) { | |||
| // Don't try to rename again if we are already renaming | |||
| if (_isInRename(entry)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _isInRename() function is expecting a DOM element, but entry is a FileEntry. You'll need to get the selected DOM element here.
It may just be easiest to put the code back where it was... Sorry about that! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It's ok. I did a fast test and it worked, so I submitted the change, but I might have been using the old version even after reloading the second window.
|
Thanks! Merging. |
gruehle
added a commit
that referenced
this pull request
Apr 24, 2013
Fix #2641: Input field change to blank after double click F2 to rename the file - few user will encounter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This adds a renaming flag, so that when F2 is pressed for the second time, the code does nothing, leaving the renaming as it was, which fixes issue #2641.