| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 15 Jul 2025 12:28:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=342.760016,conversation_content-fragment;desc="conversation_content fragment";dur=907.130541,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=251.136872,nginx;desc="NGINX";dur=1.320874,glb;desc="GLB";dur=96.148843
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pr%2FLdMNSs%2BVXY4omnuSbigRsOjL%2BD3xRbQZ5nS7rbaU718afi08LYYqsSf08m0evCfTnqwLJYPWpioeszHhuXbQKBcDSGrCx8%2F1p1u6KF7esvtopbV%2Ff5iemnShHAg3U41sEpCffDdSfWOeyexazs3ZcgntUfzsntRKatpYIF9sLuud9FPwZPJj6aCqNbcqwFraikVHNN5mYrXrAcb2508CIc7PPBFaTCfQm8xIZfb%2Bdundpczt1FiLPovbffV2rAsH%2Fssy7iP2a2mRFcqRolA%3D%3D--V0FWaRm0Fjl1mVLr--Kbl6zlKJII1h1OWCGxR6%2Fw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.5901761.1752582511; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:28:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:28:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CEAC:325BD:890496:99E7B9:6876496F
Add/expose isVisibile, show, and hide methods for SidebarView object by lkcampbell · Pull Request #3297 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add/expose isVisibile, show, and hide methods for SidebarView object #3297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
@lkcampbell This looks pretty good.
UPDATE: Nevermind. That won't work since it's already a jQuery object. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
May 15, 2013
Add/expose isVisibile, show, and hide methods for SidebarView object
| * Returns the visibility state of the sidebar. | ||
| * @return {boolean} true if element is visible, false if it is not visible | ||
| */ | ||
| function visible() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was merged already, but naming this function isVisible() would have been better, since it checks for the visible state and returns a boolean.
The same would apply to the new method in Resizer.js.
Maybe it could be changed as code cleanup before the Sprint ends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion either way. They both sound good to me.
If you guys want me to change the name I will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @TomMalbran. @lkcampbell Yes, please change it to isVisible().
|
@redmunds and @TomMalbran, new pull request with cleanup submitted. |
redmunds
added a commit
that referenced
this pull request
May 17, 2013
Cleanup for pull request #3297
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
For Issue #1187
Added public API functions for SidebarView object: show(), hide(), and visible().
Changed public API function: toggleSidebar() to toggle().
Did a find in files for current Brackets codebase and all currently listed Brackets extensions. toggleSidebar() is not used anywhere except for locally in SidebarView.js.
Ran unit tests without any problems. I'm not sure that SidebarView has any unit tests right now. If you want me to research and possibly create unit tests I can. Otherwise, this fix is complete and ready for review.