| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 03:26:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=300.391696,conversation_content-fragment;desc="conversation_content fragment";dur=649.176348,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=202.949667,nginx;desc="NGINX";dur=0.495417,glb;desc="GLB";dur=96.205443
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=EFq%2FUAqA3elluAtFNhCk8tNpT3%2FSFShhJXE1QJ2wR4ZfUG4jdfpaaZbzFjCzqB9GcFwEAZUbSGnXZ82RZe7fGhz6HDzNNSTdd0At7uE0WVQI%2FC90yLZ2lInBHitnOtcQUovQibakxhGT%2FTNLN4X3juLIz085Cf9xzkXKDK2%2B2nrxvlvzwH3EkS7DMdamIrVlRvTk274TDzB6M%2FhK85PLAdyb9eQJsPS0SgjqPqptCoaii%2FhceMdq0e9MOyPFd3nZ73OOQaCzTl9fRtnThIut%2BQ%3D%3D--mfRk5Spokr1knD6J--MHsZvd8zrH6Go9cplw9q9w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.37918876.1752895599; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 03:26:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 03:26:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EBDE:AA839:48262:67A7E:687B106F
Fixed: #3032 KeyBindingManager no longer warns / prevents binding collisions by WebsiteDeveloper · Pull Request #3081 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fixed: #3032 KeyBindingManager no longer warns / prevents binding collisions #3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
@WebsiteDeveloper are you on win or mac? On your branch, I get the following console error on mac: This works out to be okay. Cmd-G is assigned to |
| if (existing) { | ||
| if (!existing.explicitPlatform) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #3032, what happens is that the extension tries to replace a cross-platform Ctrl-E/Cmd-E binding with another cross-platform Ctrl-E/Cmd-# binding. I think a more correct fix might be to check the new binding for an explicit platform and only override it in that case:
if (!existing.explicitPlatform && existingPlatform) {
// remove the the generic binding to replace with this new platform-specific binding
removeBinding(normalized)
} else {
console.error(...);
return null;
}
|
Initial review complete |
|
@jasonsanjose i adressed your remark |
|
Merging |
jasonsanjose
added a commit
that referenced
this pull request
Mar 11, 2013
Fixed: #3032 KeyBindingManager no longer warns / prevents binding collisions
|
FYI, I just double checked the KeyBindingManager unit tests because we had two merges on KeyBindingManager.js fairly close to each other. I wasn't getting an error in my branch but I am getting an error now. I don't know if it is because of my change or @WebsiteDeveloper 's change or a combination of both, but it is there now. |
|
@lkcampbell it happens actually because of my changes, but jasonsanjose already set up a pull to fix this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fix for #3032