You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for #3012 in response to #2934 reworking the _getContributorsInformation function to return the $.getJSON call directly, as well as add a "graceful" fail message as suggested by @njx.
Hoping this could get merged into spring 21 rather than being pushed to 22.
Update the _getContributorsInformation function to return the $.getJSON call which is basically the deferred being returned anyway.
Add a "graceful" fail statement that hides the spinner and add a message for the user.
The reason will be displayed to describe this comment to others. Learn more.
I think you should just remove this function and replace _getContributorsInformation() and inside _handleAboutDialog() just call $.getJSON(brackets.config.contributors_url) as @njx proposed.
Cool, thanks for jumping on this @TuckerWhitehouse and @TomMalbran. Tom--if this looks good to you, feel free to merge now--we won't be closing the codebase for the sprint until some other stuff is merged anyway.
For the next time, you might want to consider using branches instead of pulling directly from your master, it helps a lot when the request takes longer to be merged, since you can just leave it there and work on other stuff on other branches or in the master.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #3012 in response to #2934 reworking the _getContributorsInformation function to return the $.getJSON call directly, as well as add a "graceful" fail message as suggested by @njx.
Hoping this could get merged into spring 21 rather than being pushed to 22.