| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 16:38:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=253.00656,conversation_content-fragment;desc="conversation_content fragment";dur=723.364351,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=210.832857,nginx;desc="NGINX";dur=0.684706,glb;desc="GLB";dur=101.391641
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=l0yO3tVgzrlwB9c1NAtP4YXc4NLhT69UHe3Sc6FB02OhPpZOyPABq%2BNDKLdxQb9uXaPy62tz8iOD050aQuqHzB5qLuWJrlfzEkNdysn64j1TbUM2Rh8qW3rLTB4%2FstIihVWsdAghCXQOu6pGGrZMMGzSS%2FECKr8p5FWyVhZf2rowrPJ4wZRrciQDP%2BKYzU9wDuruQTPWf4rlt8vccXgpdMXmOomjv9ccHfFXzISlbEf39n0615NuIWwY5lkZW%2BbWlv8ZCJcUhiUZ7Y9bGb%2FvGQ%3D%3D--bhC2k3kWjT21%2BTZS--XmhQP%2F5UdK4cOO2x22wr5Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1113857393.1752511082; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:38:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:38:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 86B4:DF73D:CAB24D:EDAB5A:6875326A
Upgrade to Require 2.1.1 and catch errors during extension loading by peterflynn · Pull Request #1968 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Upgrade to Require 2.1.1 and catch errors during extension loading #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oading (ensuring APP_READY fires even if an extension is broken). Also: ensure APP_READY fires in the event the entire extensions dir is inaccessible; and improve reporting of exceptions thrown by APP_READY or HTML_READY handlers.
|
Note: this breaks the PhoneGap Build plugin because it's using a RequireJS API that was removed in 2.x. I've put up a pull request to fix it: adobe/brackets-phonegap#27. |
ghost
assigned
| console.log("Exception when calling a 'brackets done loading' handler"); | ||
| console.log(e); | ||
| console.error("Exception when calling a 'brackets done loading' handler:"); | ||
| console.error(e.stack); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do both of these lines need to be console.error()? If an exception is thrown, it shows up as 2 errors in the console.
|
Done with initial review. I've been running this branch for a while now and everything is working great (except the phonegap build plugin, as you noted). I wonder if the stack dumps should be console.log() instead of console.error(). The preceding line is always an error anyway, so I don't think we need an additional error badge. |
Fix JSLint error that was introduced by 301289b.
|
Changes pushed. I also fixed a JSLint warning I happened to notice in an unrelated unit test file. |
|
Looks good. Merging. |
gruehle
added a commit
that referenced
this pull request
Oct 29, 2012
Upgrade to Require 2.1.1 and catch errors during extension loading
This was referenced Nov 2, 2012
This was referenced Nov 6, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This ensures APP_READY fires even if an extension is broken.
Also: ensure APP_READY fires in the event the entire extensions dir is inaccessible; and improve reporting of exceptions thrown by APP_READY or HTML_READY handlers.