When Find has no results, turn search field bg color red #1914

peterflynn · 2012-10-22T22:06:23Z

When Find has no results, turn search field bg color red. Less ambiguous than old behavior where selection disappears w/ no other feedback.

Also fix indentation in search bar LESS code, and move one misplaced Dialog style to the right LESS file.

than old behavior where selection disappears w/ no other feedback. Also fix indentation in search bar LESS code, and move one misplaced Dialog style to the right LESS file (with better docs).

redmunds · 2012-10-23T05:10:19Z

src/styles/brackets_patterns_override.less

@@ -363,6 +363,11 @@
    font-weight: @font-weight-semibold;
 }

+/* Any Dialog text in this style is automatically turned into a link that opens in the browser. Use data-href for the link's target. */


This is currently only used in a dialog, but it's not limited to dialogs.

Only text used in a dialog will actually get turned into a clickable link though -- since the style implies actual functionality changes there, it seems fairly closely bound to Dialog for now.

redmunds · 2012-10-23T05:13:54Z

src/styles/brackets.less

+    margin: .3em .3em;
+    color: inherit;
+    &.no-results {
+        background-color: mix(@background-color-3, #FF0000, 70%);


Usually when I see this pattern , the text is also changed to white.

It seems mixed: Firefox uses white on red, but Chrome and IntelliJ keep the text black (albeit in IntelliJ at least the red is quite pale). You think it would look better if I make the background a bit paler?

I just thought I'd mention it to make sure you considered it. It's ok as is and we can listen for feedback.

redmunds · 2012-10-23T05:15:16Z

Done with initial review. This looks cool. Just a couple minor comments.

redmunds · 2012-10-23T16:02:56Z

Looks good. Merging.

When Find has no results, turn search field bg color red

When Find has no results, turn search field bg color red. Less ambiguous

1acded2

than old behavior where selection disappears w/ no other feedback. Also fix indentation in search bar LESS code, and move one misplaced Dialog style to the right LESS file (with better docs).

redmunds reviewed Oct 23, 2012
View reviewed changes

ghost assigned redmunds Oct 23, 2012

redmunds reviewed Oct 23, 2012
View reviewed changes

redmunds added a commit that referenced this pull request Oct 23, 2012

Merge pull request #1914 from adobe/pflynn/red-no-results

7be85a1

When Find has no results, turn search field bg color red

redmunds merged commit 7be85a1 into master Oct 23, 2012

core-ai-bot mentioned this pull request Aug 29, 2021

[CLOSED] When Find has no results, turn search field bg color red brackets-archive/bracketsIssues#1863

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

When Find has no results, turn search field bg color red #1914

When Find has no results, turn search field bg color red #1914

Uh oh!

peterflynn commented Oct 22, 2012

Uh oh!

redmunds Oct 23, 2012

Uh oh!

peterflynn Oct 23, 2012

Uh oh!

redmunds Oct 23, 2012

Uh oh!

peterflynn Oct 23, 2012

Uh oh!

redmunds Oct 23, 2012

Uh oh!

redmunds commented Oct 23, 2012

Uh oh!

redmunds commented Oct 23, 2012

Uh oh!

Uh oh!

When Find has no results, turn search field bg color red #1914

When Find has no results, turn search field bg color red #1914

Uh oh!

Conversation

peterflynn commented Oct 22, 2012

Uh oh!

redmunds Oct 23, 2012

Choose a reason for hiding this comment

Uh oh!

peterflynn Oct 23, 2012

Choose a reason for hiding this comment

Uh oh!

redmunds Oct 23, 2012

Choose a reason for hiding this comment

Uh oh!

peterflynn Oct 23, 2012

Choose a reason for hiding this comment

Uh oh!

redmunds Oct 23, 2012

Choose a reason for hiding this comment

Uh oh!

redmunds commented Oct 23, 2012

Uh oh!

redmunds commented Oct 23, 2012

Uh oh!

Uh oh!