You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final step (hopefully) on the sidebar resize refactorization proposed initially in #1811 and developed in several steps in #1820, #1838 and #1899
It moves almost all the resize functionality for the sidebar into the utils/Resizer module.
Due to the last changes on flexbox, it also adds a new data-forcemargin to control the margins that need to be pushed while resizing an element.
@redmunds With a bit of luck this could be the end of the Resizer chapter for now ;)
In master, the area that shows the resize cursor is to the right of the panel edge, but in your branch it's too the left of the panel edge. Logically, I think it makes more sense to have the resize area over the panel that's being resized, but it causes a problem in this case because it's over the vertical scrollbar. It makes it difficult to grab the scrollbar with the mouse -- there's only 1-2 pixels where you can grab it.
@redmunds On a side note, now that #1854 is fixed, I was thinking of adding a second pass (first one needs to stay on htmlReady to catch the sidebar size as soon as possible) in the Resizer on appReady. Hopefully it will be able to catch now the html resizer attributes for the extensions without the manual call to makeResizable. What do you think?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final step (hopefully) on the sidebar resize refactorization proposed initially in #1811 and developed in several steps in #1820, #1838 and #1899
It moves almost all the resize functionality for the sidebar into the
utils/Resizer
module.Due to the last changes on flexbox, it also adds a new
data-forcemargin
to control the margins that need to be pushed while resizing an element.@redmunds With a bit of luck this could be the end of the Resizer chapter for now ;)