Reviewing

Looks like there are some additional references that use e.which instead of e.keyCode in widgets/Dialogs. Would you update those as well?

Initial review complete.

Sure - will make the changes.

Thanks for the through review - i was rushing it a bit this morning

@RaymondLim : I did think about that, but I looked it up. Turns out the original definition
per also defines the code as VK_EQUALS
https://www.javascripter.net/faq/keyeventconstantsfirefox.htm

Note - I redefined the code as the brackets uses 187.
KeyEvent.DOM_VK_EQUALS = 61

•    DOM_VK_EQUALS: 187,
  

Also, why plural here? should be VK_EQUAL.

@couzteau

I googled on VK_EQUAL and found out that there are two camps. So I'm okay to keep it as is.

BTW, there are some hard-coded key codes in CodeHintManager.js that you need to replace with your changes too.

Thanks Ray - I'll take a look at Code hinte manger as well as the tests and update the pull request.

Hi Jochen. Looks like you need to sync up with master before we can merge.

Thanks for the info - won't get ti it before tonight.

@couzteau please also sign the CLA before I merge this pull request https://dev.brackets.io/brackets-contributor-license-agreement.html

done

Thanks. Merging.

Yay! Thanks -my pleasure.