| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 16 Jul 2025 22:03:41 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
etag: W/"ccfec25c0acedae4d31f1874b434699d"
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ymSs%2BB9cWYKb5R%2B3JLfJXwlyYe8Yrg0ZXZwJfkeUoCJEufy5nT7HXEq9SLPG2lL%2FY9xQhScWYmHOQdorelHrp96VWavL1QnorjF9jKkeCg2dakZnJaY%2FztpVz28ThBq%2BzNH21kU%2B9L7vi8K%2BhW%2B75Y%2BLtXjkUAtl%2BAkua7vS9IVwwlDzq5UKuFHDfSj5hvuubdijrM9U0KKV85W%2F1yW5Q0fX1ObLJ2w18%2FQxgidBTY%2BwSvrplSD2pY4bC15KTUuR4iU0j9VzrTY3THnRQexjfA%3D%3D--F0SoPvGN4vn4Sn%2FD--04nVu888pORVDGuYDMpaPA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1746917165.1752703419; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 22:03:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 22:03:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 85E8:11AB5:E4C8D:13E5B1:687821BB
jsRefactor Rename Relative Path issue fixed by niteskum · Pull Request #14520 · adobe/brackets · GitHub
niteskum
changed the title
jsRefactor Rename Realtice Path issue fixed
jsRefactor Rename Realtive Path issue fixed
Aug 24, 2018
niteskum
changed the title
jsRefactor Rename Realtive Path issue fixed
jsRefactor Rename Relative Path issue fixed
Aug 24, 2018
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
jsRefactor Rename Relative Path issue fixed #14520
Merged
boopeshmahendran
merged 2 commits into
adobe:master
from
niteskum:jsRefactorRenameIssue
Aug 27, 2018
Merged
jsRefactor Rename Relative Path issue fixed #14520
boopeshmahendran
merged 2 commits into
adobe:master
from
niteskum:jsRefactorRenameIssue
Aug 27, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niteskum
changed the title
niteskum
changed the title
boopeshmahendran
suggested changes
Aug 27, 2018
| @@ -98,7 +99,17 @@ define(function (require, exports, module) { | |||
|
|
|||
| function isInSameFile(obj, refsResp) { | |||
| // In case of unsaved files, After renameing once Tern is returning filename without forward slash | |||
| return (obj && (obj.file === refsResp.file || obj.file === refsResp.file.slice(1, refsResp.file.length))); | |||
| var projectDir = ProjectManager.getProjectRoot().fullPath, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if ProjectManager.getProjectRoot() returns null
|
|
||
| // get the relative path of File as Tern can also return | ||
| // references with file name as a relative path wrt projectRoot | ||
| // so refernce file will be compared with both relative and Absolute path ti check if it is same file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix typos
boopeshmahendran
approved these changes
Aug 27, 2018
nyteksf
pushed a commit
to nyteksf/brackets
that referenced
this pull request
Sep 8, 2018
author Nitesh Kumar <38075523+niteskum@users.noreply.github.com> 1535377091 +0530 committer nyteksf <email.nytek@gmail.com> 1536424652 -0700 jsRefactor Rename Relative Path issue fixed (adobe#14520) * jsRefactor Rename Realtice Path issue fixed * Addressed review comments Delete .gitignore Exclude .gitignore, config.json Repair error, Refactor error handling for localStorage Add package.json to merge repos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Rename doesn't work if TernNodeDomain return Refs with path relative to project Root.
So added check it will compare both Absolute path and Relative path so if either of these is true Refs will be considered in same file.
@boopeshmahendran @navch please review