You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I see that if updateJsonHandler.parse() fails, the code flow lands in initState, which in turn is calling updateJsonHandler().parse again. I think you can restucture the code for better readability as well as for proper code flow.
The reason will be displayed to describe this comment to others. Learn more.
Restructured the Code. , Removed the CheckUpdateStatus() from initNode() function. Now initNode Function returns Promise . which is resolved when parsing is done. initNode is called and in done function checkUpdateStatus() function is called.
@nethip In setupAutoUpdate() function initNode() and initState() function were called one after another. So there were no synchronization between setUpdateInProgressState() and CheckUpdateStatus()
InitNode Function notifies Brackets to reset inProgress Flag when Bracket is launched. and initState() function used to call checkUpdateFunction() which cleans up Update Temp Folder If Update was initiated in prev session. sometime UpdateTemp were being cleaned up before setting up the flags. and Exception were thrown in setUpdateInProgress() function because there was no File to write.
Changes in this PR:
Renamed the function "setAutoUpdateInProgressFlag" to "nodeDomainInitialized". and from initNode Function Node Notifies to Brackets to execute "nodeDomainInitialized" function and pass a parameter "reset" which is true If Brackets is launched. and false If New Brackets Window is opened.
and in nodeDomainInitialized function , initState() Function is called . and resetting of "InProgress"Flag and checkUpdateStatus() are executed in sequence.
so this makes sure There is No RaceCondtion between resetting the flag and cleaning up the temp folder.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.