You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspector and agents now use jQuery events. I mapped Inspector.on and .off to jQuery's methods to make migrating to the new events easier. Feel free to take these methods out (they are not used).
LiveDevelopment.open() now returns a promise
I removed the load event handler (it is triggered otherwise)
Status codes are now constants (the mapping remains the same to support >= STATUS_CONNECTING to check if there is an connection attempt or an active connection in one line)
I'm seeing 1 unit test failure in Live Development "should establish a browser connection for an opened html file"
Error: An attempt was made to use an object that is not, or is no longer, usable.
at _send (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/Inspector/Inspector.js:143:17)
at Object.close (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/LiveDevelopment.js:443:31)
at cssOpened (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/spec/LiveDevelopment-test.js:124:33)
at jasmine.Block.execute (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
at jasmine.Queue.next_ (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
at goAgain (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1832:18)
timeout: timed out after 10000 msec waiting for Waiting for to close inspector
I do not get this error, and do not understand how it can occur. The variable in question (Inspector.js:143:17) is method, which is not an object but a string. The call that is issued is window.close() on the client side to close the active tab after a live development session. Can you try closing an active live development session manually and verify that the error actually occurs?
Other than that, I am not sure how I can help in fixing this issue.
I'm seeing 1 unit test failure in Live Development "should establish a browser connection for an opened html file"
Error: An attempt was made to use an object that is not, or is no longer, usable.
at send (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/Inspector/Inspector.js:143:17)
at Object.close (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/LiveDevelopment.js:443:31)
at cssOpened (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/spec/LiveDevelopment-test.js:124:33)
at jasmine.Block.execute (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
at jasmine.Queue.next (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
at goAgain (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1832:18)
timeout: timed out after 10000 msec waiting for Waiting for to close inspector
—
Reply to this email directly or view it on GitHub.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
assigned
As suggested in #1340:
loadevent handler (it is triggered otherwise)