| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 17 Jul 2025 00:34:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=290.826921,conversation_content-fragment;desc="conversation_content fragment";dur=771.046809,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=260.063608,nginx;desc="NGINX";dur=0.744317,glb;desc="GLB";dur=96.147402
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=dgt51NC%2Fk2o9oKe1AgFyG7R4Pj4EmfwOjFWMibJYYO5kAcqn%2FUeQvfXX6xykFTwbLgUdEU5higoraGIp08EGRuKqo0a4ZsmnmXSck9rlDlNj2i932EKl%2FCvV9%2F2272IZa6aTxdnOQZ5%2BvAHxYYiQX3ZV2UxC4qcPvfbbVPOVz9s8vBj0N0yL281AEuscNQuRuFv2c77Q%2BqgVuIhSQdI8eXj5G9LdTvb8WKfoFlj2wEI71Rc2mBZBC2PS1sTvnlAg%2Bx68XpyH3XUjYvgsSv3wPQ%3D%3D--gToDhoEvS8bBl6An--QbodBk%2B45bGU6UyREvq6kg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1055808622.1752712440; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:34:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:34:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B7D0:4AC1B:2BA8E:44B93:687844F8
Now reverse inspect can be disabled by setting the 'livedev.enableReverseInspect' pref to false by saurabh95 · Pull Request #13659 · adobe/brackets · GitHub
swmitra
changed the title
Now reverse inspect can be disabled by setting the livedev.wsPort to 0
Now reverse inspect can be disabled by setting the 'livedev.enableReverseInspect' pref to false
Sep 18, 2017
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Now reverse inspect can be disabled by setting the 'livedev.enableReverseInspect' pref to false #13659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petetnt
reviewed
Sep 5, 2017
| @@ -1369,7 +1369,10 @@ define(function LiveDevelopment(require, exports, module) { | |||
| // wait for server (StaticServer, Base URL or file:) | |||
| prepareServerPromise | |||
| .done(function () { | |||
| WebSocketTransport.createWebSocketServer(PreferencesManager.get("livedev.wsPort")); | |||
| var wsPort = PreferencesManager.get("livedev.wsPort"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use a different pref instead, such as livedef.enableReverseInspect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petetnt IMO, that might confuse a lot of users. Instead if an invalid port (0) is given by the user, it's implicit to assume that reverse inspect is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cents is that average user doesn't even know what a port is, even without considering what might be an invalid port and what isn't 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a pendulum now 😃 . I had asked the same initially to @saurabh95 but somehow got convinced with the explanation. But now I am convinced by your explanation again so would ask the author to include a new preference. @saurabh95 over to you...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for a user who is not aware of ports, it would be a difficult way to disable reverse inspect. I will add a new preference and will update this PR only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@petetnt Can you please have a look at the new pref? I have to merge this PR today and get the localized description strings as well. |
petetnt
approved these changes
Sep 18, 2017
|
Great work @saurabh95 and @petetnt 👍 |
swmitra
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes: #13307