You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR properly initialises the _lineFolds cache to the empty object when the saveFoldStates preferences is set to false. Previously, this was not being done and it caused issues down stream, i.e., when rendering gutters as the active editor changed.
Also updated the test cases to accommodate the requirement.
@thehogfather, the changes look good to me. Initialize the uninitialized property with an empty object and get rid of the undefined/null error message down the road.
Is _codeMirror._lineFolds where you are storing all of the fold state information for each instance of CodeMirror opened in brackets?
The only problem I see is the Travis build is failing. @ficristo or @petetnt any ideas what might be causing the build fail?
Is _codeMirror._lineFolds where you are storing all of the fold state information for each instance of CodeMirror opened in brackets?
Yes that is correct.
With respect to Travis failing, I'll pull upstream and push to trigger the build again. The error messages show it did not get very far into the build process.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR properly initialises the
_lineFolds
cache to the empty object when the saveFoldStates preferences is set to false. Previously, this was not being done and it caused issues down stream, i.e., when rendering gutters as the active editor changed.Also updated the test cases to accommodate the requirement.
cc @lkcampbell @ficristo