This upgrade bring quite a few bug fixes accumulated through 22, 23 and 24. I would also like to see use of sticky prop in position. Good upgrade for Brackets 1.9 👍

This breaks a lot of tests. You need to change them to consider the new sticky property.

Yes @ficristo. For now to leverage on the bug fixes and mode optimizations we can just upgrade the CM version, but to actually use the new features we need a complete development cycle which we can't have for Brackets 1.9. Do let us know if you think that this upgrade alone might cause problems.

For what I looked we only need to adjust our tests.
This only mean that before we checked for {line: x: ch:y} now we need to check for {line: x: ch:y, sticky: null}. We don't use new features.
Hopefully this is the only change for all breaking tests.

I believe I have resolved test issues, can you please re-check guys?

Restarted the travis build and all checks are successful. Waiting for @ficristo to approve this PR and we can merge then.

There were still some failures on extensions tests.
(There were other failures but probably related to my system)

I just noticed 5.24.2 was released. Better upgrade to it.

Upgraded to 5.24.2, sadly something is not right with unit testing on my machine. Some tests do randomly pass and fail and then I try to open developer tools to debug, the whole testing window just freezes, quite terrible development experience.

I will also try to see if I can run the tests and figure out any particular issue @zaggino.

thanks, yesterday all integration tests were passing with this PR and now they are randomly failing, drives me mad but i'll give it a try again probably tomorrow

fixed (hopefully all) extension unit tests, @ficristo can you please have a look and let me know which (if any) particular tests still fail because of this PR?

It seems there are still some failures with Extensions \ JavaScript Code Hinting and Extensions \ JSQuickEdit.
NOTE: I reverted 7883b01 before testing. See #13126

@ficristo fixed those tests, also added a fix for #13126 - 1de6b88?w=1

Thank you for all the effort.