You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes#12970 by removing invalid mappings from the preference state, occurring when a language has not been loaded yet. When the language is eventually loaded, an _updateFromPrefs call restores the preferences.
@zaggino Just tested it again on Windows & Ubuntu with the latest master and it works fine with the steps described in the issue. I may have missed something so I'll take another look later
Better way of dealing with this bug is just to remove invalid mappings
from the prefs state, and force an _updateToPrefs call when defining a
non-default language
I was able to produce a fix for the steps in the issue but I didn't try using .twig files (issue describes step 2 as any file type that's not supported). I can now see that overriding .twig is a specific scenario that doesn't work, but all other extensions are fine.
So I've added a fix for this as well. You can now override .twig files and make it work with the Twig language.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #12970 by removing invalid mappings from the preference state, occurring when a language has not been loaded yet. When the language is eventually loaded, an
_updateFromPrefs
call restores the preferences.