You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to #12963
I was wondering if, instead of this approach, we could use some other tool to copy node_modules like using browserify, webpack or others.
Yeah, definitely prefer this one over all the others. Only thing that bothers me a little bit is the generation of npm-shrinkwrap file since you need to do that from src folder AND not to forget about it 👍
That'd mean introducing another tool, we'd have to use yarn instead of npm install, not sure how yarn works with npm install scripts... to be honest I don't think yarn is worth the complexity it adds.
I agree with introducing another tool being cumbersome, but it's a tool that's fully compatible with npm and pretty much improvement in every way (especially with speed and security), especially if we need to fiddle around with npm-shrinkwrap which is basically somewhat broken at this point.
For the grunt script the work needed would be basically s/npm install/yarn, plus with enforcing --pure-lockfile we could ensure that right deps would always be installed.
Disclaimer: I have only used yarn after it came out and I am a huge fan 😸 Not saying that we would need to do it right now (or ever), we can punt it into an issue and think about it later too 👍
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #12963
I was wondering if, instead of this approach, we could use some other tool to copy
node_modules
like using browserify, webpack or others.Ref #12940