You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this great PR @mansimarkaur! Tested against latest master and it works great.
Could you add few small pieces of JSDoc for the new methods and maybe simple unit test for the functionality? (it should disable context menu items when not present and it should not disable context menu items when present)
@mansimarkaurtest/Menu-test.js sounds like a good place.
Any specific things you need help with the tests? The structure should could be something like:
it("it should disable context menu items when file doesn't exist ", function () {
// runs create a new file
// opens context menu
// checks that all the items are disabled
})
it("it should enable context menu items when file does exist ", function () {
// runs create a new file and saves it
// opens context menu
// checks that all the items are enabled
})
For example check DocumentCommandHandlers tests to see how the working set can be manipulated.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11763