| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 14:33:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=443.675456,conversation_content-fragment;desc="conversation_content fragment";dur=1158.539572,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=341.711707,nginx;desc="NGINX";dur=1.224042,glb;desc="GLB";dur=725.058933
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=rbfYUzuQi3wZAUmc67QhNwJXNCkpFiJ3l1GT7EH3x9PjX3NUP0E6DZTBXglu6z6Z02dC1mn9Agq1VVGavBOFyfKr2qnd9oR9MJnki8xm6fvgKFYeV71eSk%2FiA8Sazi98zAxB8BuMbPqbB9jaWXoDGknz2%2F36K1GpZE42hW%2FAMocdhgG33sQY6h4S6WoKNKRqugNYeyZW%2BP66VrVLj8v7EQ7JTxEhvQXaH9SHreO3y28k4iL9aEXBZpPZ1UnURo%2BTiHPCdCzNTqKlvzO4kKCgFw%3D%3D--wNbLoQdyxX0yj4FV--8jR1HF%2FKmgvbRkJBVeVY1A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.563354472.1752503607; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 14:33:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 14:33:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E416:3CE70B:137AC1C:181D9D0:68751537
Adding a Save All menu item under File by srinarasi · Pull Request #1208 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Adding a Save All menu item under File #1208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -429,6 +429,14 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Saves all the unsaved files. | |||
| * @param {?{doc: Document}} commandData Not used in this function. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unused argument
|
Also: would you be willing to submit a squashed pull request? We don't have any hard and fast rules on this yet, but 5 commits for a small diff like this feels a little high... so if it's not too much trouble, it'd be nice to squash it down to just 1. |
ghost
assigned
Updated getModeFromFileExtensions to let cfm and cfc files use the html editor. This will make any ColdFusion developers experience with brackets much much better. Update master Update About dialog sprint number Update _shouldShowInTree to only hide specified hidden files. Solution for adobe#1133 Replace $.isArray with Array.isArray Adding comment for the handleFileSaveAll function Edited the comment Adding different shortcuts for Mac and Win
|
I've squashed them all and have pushed it. I'm still learning git and am not sure if I've done everything right. If there's something wrong, please let me know. |
|
Sorry for the delayed response -- I should have mentioned that we were on break all last week. Just a couple more nits -- see comments in the diff. |
| @@ -429,6 +429,14 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Saves all the unsaved files. | |||
| * @param None | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to explicitly say this -- just leave off the @param line entirely.
|
@srinarasi -- if you have a chance to address those last three nits, then we can merge this right away! |
|
Sorry about the delay. I'll try to fix them today. |
|
No worries -- whenever you have time |
|
@srinarasi: we decided to just merge this as-is, and I'll commit those last cleanups on our end (along with the shortcut change proposed by @RaymondLim). Thanks for contributing! |
peterflynn
added a commit
that referenced
this pull request
Aug 2, 2012
Add a Save All command (implementation already exists, just exposing it in the UI now)
peterflynn
added a commit
that referenced
this pull request
Aug 2, 2012
This is a follow-up to original pull request #1208, which has already been merged. See comments there for discussion of these changes (particularly the shortcut debate).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
It's a very simple change to add an option to save all the unsaved files. I'm just calling saveAll() from my handler.