You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #9311. Adds a new pref lineWiseCopyCut (still enabled by default) to suppress copy/cut from copying/cutting a whole line when there's no selection.
I don't think this is quite the issue reported. The problem was not whole-line cut/copy as a feature, but that it copy/pastes a totally blank line when used on a blank line. The desired fix was for it to not activate at all on blank lines. The issue, as I already detailed, is the "\n" CodeMirror always adds to the end of the copied line. With those removed (more like added only under proper circumstances), using whole-line cut/copy on a blank line works as desired (and also as I said, remedies a number described in #9130).
EDIT: I could be reading this all wrong and this PR does exactly what needs to be done instead of completely disabling the feature (as I initially thought). Apologies if that is the case. :\
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9311. Adds a new pref
lineWiseCopyCut
(still enabled by default) to suppress copy/cut from copying/cutting a whole line when there's no selection.See also https://codemirror.net/doc/manual.html#option_lineWiseCopyCut.