You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue like this on CodeMirror: can we use that logic?
The code on CodeMirror changed since this PR, can you update the PR to reflect the new changes?
If there aren't specific requests, can you avoid exposing the setter/getter of scrollbarTrackOffset?
I've already had the appropriate code in there to calculate the scroll height, but I've changed it because CMs code seems to be a tiny bit faster.
The reason the getter and setter is exposed is maybe a bit selfish, but my extension Scroll Arrows would make use of them (it's probably the only one that does so, though).
Since you have an use case I'm fine with the setter/getter.
@marcelgerber @dakaraphi do you know how this will interact with #12442?
I don't see any changes there on ScrollTrackMarkers.js file but I wonder if there could be any problem.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11079.
This does not only fix the
"scrollPastEnd"
issue, but also ones where scroll tick marks were inaccurately placed in minified lines, and so on.Also adds new
getScrollbarTrackOffset
/setScrollbarTrackOffset
methods which can be utilized by extensions.Notice though that this new method is more expensive, so we should look out for performance regressions!