CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Added over 200 new strings en removed obsolete strings from older Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.
Thanks for your contribution! |
@coreice As brackets is an open source project, The contributor license agreement is for your protection as well as the protection of Brackets and its licensees; it does not change your rights to use your own Contributions for any other purpose. |
@abose I'm aware of that. I hope my contribution will be approved. |
@coreice have you signed the CLA? |
@abose He has (according to |
"SPLITVIEW_MENU_TOOLTIP" : "Splits de editor verticaal of horizontaal", | ||
"GEAR_MENU_TOOLTIP" : "Configureer bestanden", | ||
|
||
"SPLITVIEW_INFO_TITLE" : "Al geopend", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this line is indented one space too much
@ispieter @githrdw Would you mind doing a quick review on these changes & additions to the Dutch translation? |
@coreice Could you update this PR. |
Yes, I see several errors in the translations. @abose, what is the best way to mark these? Should I leave a comment on all of them? |
If you can mark these errors I will fix them. |
@ispieter It's best to add a line note to every line you'd like to be changed. @coreice Please make sure you fix the linting errors and the missppelled key, too. |
"EXCLUDE_FILE_FILTER" : "Sluit {0} uit", | ||
"EDIT_FILE_FILTER" : "Bewerk\u2026", | ||
"FILE_FILTER_DIALOG" : "Bewerk set uitgesloten bestanden", | ||
"FILE_FILTER_INSTRUCTIONS" : "Sluit bestanden en mappen uit met de volgende stringen/substringen of <a href='{0}' title='{0}'>wildcards</a>. Plaats elke string op een nieuwe regel.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'stringen/substringen' are no Dutch words. Perhaps 'teksten/deelteksten' is a better alternative.
These are the things that I found. The rest seems fine to me. :) |
Thanks a lot, I will process them :). I hope it will be ready this week but I've a busy schedule so it also could be next week. |
Thanks @ispieter for reviewing this. @coreice Did you get a chance to look into this? Brackets will have a release within the next two weeks. |
@abose Just returned home from a convention. Will be working on it now :). Do you want me to create a new edit and pull request after I'm done? Edit 16.02 gmt+2: done with editing the errors. |
👍 Editing this PR would be good for other reviewers to keep track of the changes. |
Fixed some errors reported by @marcelgerber and @ispieter. Also saw some other errors during the process. Line 133: Changed "Verwijdering" into "Verwijderen". Line 251, 485, 486, 500, 521, 522 & 589: These lines weren't (correctly) translated in the previous version of my translation.
Updated the PR. Thanks for checking @marcelgerber & @ispieter, there were some stupid mistakes in the previous one. I hope this one will be better :). |
@ispieter Does this look good to you? |
You should also update the SHA comment at the very bottom. This is based on 50cbe1b ( |
Fixed SHA.
@marcelgerber You're right. Fixed the SHA comment. |
Yes, looks good to me. |
Thank you @coreice @ispieter. |
Added over 200 new strings and removed obsolete strings from older (pre 1.3) Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.