You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't want to introduce progressCallback as a new argument to node functions, we can make a call callback(null, null, "progress") to invoke a progress and not resolve the promise checking for arguments.length === 3
The more I'm thinking about this, the more callback(null, null, "progress") version makes sense, but I'll wait for some opinions before fixing this PR.
@zaggino Sorry. I could not find some time to go through this PR as I was caught up with lot of other stuff. I will for sure take a look at this PR next week.
The reason will be displayed to describe this comment to others. Learn more.
@zaggino I ran the Live preview test for Node connection and the test is timing out at should receive progress events from asynchronous commands [win 8.1]. Any idea why?
Verified, merging.
The corresponding PR adobe/brackets-shell#509 in brackets shell has been merged.
Our linux builds will not pick up this change on brackets shell as we build from the older CEF branch.
So will need to manually add this before release. Adding to release 1.4 checklist #11256 .
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: adobe/brackets-shell#509
Related Issue: #7356
Please review @nethip , I'd like to get this into Brackets as this would help to improve user experience on some of my work I'm doing with extensions.