| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 14:33:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=314.674826,conversation_content-fragment;desc="conversation_content fragment";dur=1039.54604,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=283.528842,nginx;desc="NGINX";dur=1.281697,glb;desc="GLB";dur=96.052672
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=q9CnwZ5rDwSKRVzKu6mrG2StM5dVPhbCHAArc0SMr2CipnMM7stJREC45I2G9MtAlZ4hj3l91BN1Rr60By7u0G2M3ziUe3veswRYEPdPAOKfssD%2FiLlz9m8zBYvjsi3sj6jwNyEhLyW7K05e5n9HQXmTkDAfFkYVqwRhshIj5SthpQzozhhieLDW300owv84ZlFL3DOmXF1C0O3G0MT6Btm3MTFEqP2wPaJSc%2FuWodf4jNdzCAtkF%2Bp0Hro54vGPr8sa1aRaKlTnwAFP7w2NCA%3D%3D--52VE7ktAfHH%2BLTs%2F--sdJ1okrn%2BNaRC5g79gRmQA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1759248899.1752503618; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 14:33:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 14:33:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D270:3801A9:1351207:17F2BB6:68751542
Get rid of deprecation warnings in LiveDevMultiBrowser by busykai · Pull Request #10500 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Get rid of deprecation warnings in LiveDevMultiBrowser #10500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeffryBooher Can you review this small PR? It updates code deprecated by split view changes, and also updates a deprecation warning message. |
|
|
||
| if (!otherDocumentsInWorkingFiles) { | ||
| DocumentManager.setCurrentDocument(doc); | ||
| MainViewManager._edit(MainViewManager.ACTIVE_PANE, doc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can We use DocumentCommand.CMD_ADD_TO_WORKINGSET_AND_OPEN instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, but I used CMD_OPEN instead. The file is already added to the working set (right before if).
|
@redmunds LGTM -- just the one comment. |
|
@JeffryBooher, done. |
| @@ -157,7 +157,7 @@ define(function (require, exports, module) { | |||
| * @return {Array.<File>} | |||
| */ | |||
| function getWorkingSet() { | |||
| DeprecationWarning.deprecationWarning("Use MainViewManager.getViews() instead of DocumentManager.getWorkingSet()", true); | |||
| DeprecationWarning.deprecationWarning("Use MainViewManager.getWorkingSet() instead of DocumentManager.getWorkingSet()", true); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, btw!
|
@busykai probably unrelated to this change but 3 Live Dev tests fail in the MultiBrowser (experimental) test suite: I'm on Win 8.1 / Chrome Version 41.0.2272.35 beta-m (64-bit) |
|
Merging this since the test failures it doesn't appear to be related. Tested and works as expected. |
JeffryBooher
added a commit
that referenced
this pull request
Feb 5, 2015
Get rid of deprecation warnings in LiveDevMultiBrowser
@JeffryBooher, thanks for this data! Will take a look at it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In case where the
LiveDocumentdoes not have a master editor,LiveDevMultiBrowserimplementation uses deprecated methods to add it to the working set and open if there's no other documents.CC @redmunds