| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 23:53:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=261.29421,conversation_content-fragment;desc="conversation_content fragment";dur=622.916864,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=184.843095,nginx;desc="NGINX";dur=0.939974,glb;desc="GLB";dur=95.71105
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2Bj8ozBDawLDdp9hettXpTPbcbM903aro7EEhJcTE22Wq0mA%2Bu4yFl3J66Vms2AX%2BOJyaF0vU8ZpEB5FRuWTGJxJl3W3vfwjS3%2BoXn9gQpJl8mGTnhBTygnb%2BaCM3dCZx5st0AR4zhj0soM%2FJGVqRM7zBlLplPOwCIzdziww2I2K1YIydVN4WSxTXgHmqGAbRmYy9HJtkPoOkMlRYNnQ5F09tYBHaK331S8jUZ9R5UcYpoF4n5fbv3RW5HwtmCzMDrm1IOVOuHUUIz%2BCOS0rrAQ%3D%3D--CZX1ItExGP86JONe--cKMMxdEN2vn1f1oQl09ARg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.719737768.1752537198; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:53:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:53:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8FFA:B4F9F:FC4F9:178273:6875986E
Handle undefined theme the right way by marcelgerber · Pull Request #10243 · adobe/brackets · GitHub
marcelgerber
force-pushed
the
theme-undefined
branch
from
December 20, 2014 15:33
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Handle undefined theme the right way #10243
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,7 @@ define(function (require, exports, module) { | |||
| var loadedThemes = {}, | |||
| currentTheme = null, | |||
| styleNode = $(ExtensionUtils.addEmbeddedStyleSheet("")), | |||
| defaultTheme = "thor-light-theme", | |||
| defaultTheme = "light-theme", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has never caused any issues, has it?
cc @MiguelCastillo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcelgerber no we haven't ran into issues. That's because we have this https://github.com/adobe/brackets/blob/master/src/view/ThemeSettings.js#L49.
That discrepancy was introduced in the shuffling when we were trying to land themes. I have cleaned up lots of that stuff in this PR #9069 which I think we should really merge, but have not heard much feedback on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, reverted the change in this PR (as it's not necessary) to not cause any unnecessary conflicts with your PR.
marcelgerber
force-pushed
the
theme-undefined
branch
from
a82cab1 to
e906f1a
Compare
|
@MiguelCastillo Feel free to merge this :) |
MiguelCastillo
added a commit
that referenced
this pull request
Dec 20, 2014
Handle undefined theme the right way
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Sorry for the confusion.
This is the right way to do #10236.