You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chicu123: sorry we haven't gotten back to you on this yet. We'd like to spend some cycles testing this (and adobe/CodeMirror2#60) and evaluating its impact. I've added a user story (https://trello.com/card/evaluate-scrolling-performance-enhancements/4f90a6d98f77505d7940ce88/555) to track this work; we're going to try to get it into our next sprint. Thanks again for all the awesome evaluation and suggestions!
This patch produced fantastic results! There are some downsides to moving the CodeMirror instance out of the main parent hierarchy, though. I'm hoping that we could get most (if not all) of these performance gains by leaving the editor where it currently is, but changing its parents to avoid using flex-box (which as @chicu123 has pointed out, isn't well optimized in the webkit code).
So, I think what we'd like to do next is develop a variant of this patch per the above idea, and then run another round of tests to see if it still produces a big win. (And then merge it!). @chicu123, that new patch could come either from us or you, depending on who has cycles... But we'll also need to allocate some time on our end for the testing. The next clear opportunity to do that is this story, but sadly that's not scheduled for a while. Hopefully we'll be able to make progress sooner than that.
I'll close this pull request for now since I don't think we'll want to take this exact patch. But again, thanks a ton for this great work! It's really exciting to see how big an impact this change could have.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... from a root element.
This way it avoids the layout of the flex box, which affects both layout runtime and dirty rectangles sizes.