For Farsi | Persian |فارسی l Language. #10062

datamweb · 2014-12-02T19:46:34Z

Hi,
Full translation of the Farsi | Persian |فارسی l language For Brackets version 1.0.
Add Getting Started for Farsi | Persian |فارسی l language.

Add Getting Started index.html For | farsi| Persian | فارسیLanguage ------------------------------------------------------------------- صفحه ایندکس اچ تی ام ال برای زبان فارسی در زمان لود براکتس به زبان فارسی

add RTL Css for Farsi | Persian |فارسی

Image for farsiquick-edit

Updet for add Getting Start for Farsi | Persian | فارسی Language

Full Farsi | Persian |فارسی translation for Brackts 1.0. ---------------------------------------------------------- بروز رسانی ترجمه کامل فارسی برای براکتس نسخه 1.1 ------------------------------------------------------------- این فایل از ترجمه قبلی آقای محمد یعقوبی استفاده کرده است.

This reverts commit 12892b5.

busykai · 2014-12-02T20:32:36Z

@datamweb, you need to read and sign Brackets Contributor License Agreement before your contribution can be accepted.

datamweb · 2014-12-02T20:55:30Z

hi,busykai
I have read and confirmation.
Thanks for the help.

RaymondLim · 2014-12-02T21:11:13Z

src/nls/fa-ir/strings.js

-
+    "KEYBOARD_CTRL": "Ctrl",
+    "KEYBOARD_SHIFT": "Shift",
+    "KEYBOARD_SPACE": "Space",


@datamweb Why are you removing white spaces before the colons? They are there for vertical alignment of the colons. Can you put it back so that we can see the actual diff of translation changes?

Hi,RaymondLim
I used brackets-beautify EX. This problem has been created automatically.
And I'm not sure who made the changes.
I resolved soon...
thanks...

busykai · 2014-12-02T21:15:50Z

There's been also a change to CM in the middle. This will have to be squashed once it's ready.

RaymondLim · 2014-12-02T21:21:18Z

src/nls/fa-ir/strings.js

+    "UPDATE_AND_RELOAD": "بروزرسانی افزونه ها و بارگذاری مجدد",
+    "PROCESSING_EXTENSIONS": "درحال پردازش تغییرات\u2026",
+    "EXTENSION_NOT_INSTALLED": "ناتوان در حذف افزونه {0} زیرا این افزونه بدرستی نصب نشده.",
+


@datamweb Not sure you have any translation for new and updated strings. If you do, you also need to update SHA to the version you're using for this pull request. See https://github.com/adobe/brackets/tree/master/src/nls/README.md for updating SHA.

This link is a good guide.
Thank you for posting it.

fix white spaces and SHA.

for delete "APP_NAME" : "براکتس",

datamweb · 2014-12-05T16:44:28Z

I tried to fix your things said.
Is there another problem?
Please help?

RaymondLim · 2014-12-05T17:38:49Z

src/nls/fa-ir/strings.js

 });
-/* Last translated for 91b392bf349ece5058595b26a11c651697ee7ff6 */
+/* Last translated for 2467f386b17b03a7039148298fe785d54d1e6b8d */


This doesn't look like a correct SHA for root strings.js file. You need to get the correct SHA from this.

HI,Thank you for your response.
Please check done right.
If true, I've noticed how should I replace SHA.

fix SHA.

RaymondLim · 2014-12-05T19:17:39Z

samples/fa-ir/Getting Started/index.html

+[:::::::::::::: ::::::::::::::]
+[:::::::::::::: ::::::::::::::]
+[[[[[[[[[[[[[[[ ]]]]]]]]]]]]]]]
+-->


Nit: Why do you have to use Beautify or whatever to remove all the whitespace? This breaks all the proper indentation. I'm fine this way, but it will be nice if you can restore the proper indentation for easier viewing of the html code.

fix [CODE THE WEB] Beautify.

RaymondLim · 2014-12-05T19:21:13Z

@datamweb Can you find someone to do the linguistic review of your translation?
@mohammadyaghobi Can you review the translation?

RaymondLim · 2014-12-05T19:35:36Z

samples/fa-ir/Getting Started/rtl_main.css

+    max-width: 800px;
+    direction: rtl;
+    text-align: right;
+    font-family: "tahoma", Helvetica, Arial, sans-serif;


It looks like you're changing font-family property and adding direction to the original main.css file. If so, I don't think you need to add this file. Instead, add the following rule to main.css file and then add class="rtl" to your body tag.

.rtl { direction: rtl; font-family: your-font-stack; }

tanks,Fix class rtl to body tag

You also need to remove this file and make the necessary to the main.css file.

RaymondLim · 2014-12-05T20:14:29Z

samples/fa-ir/Getting Started/rtl_main.css

+    direction: rtl;
+    text-align: right;
+    font-family: "tahoma", Helvetica, Arial, sans-serif;
+}


You missed my point. I was telling you not to add a new css file for Farsi language. Instead, just add this rule to the end of main.css so that other right to left languages can also use the same class in their index.html files.

I did not do. Because, each sample has a separate CSS file.

datamweb · 2014-12-12T17:30:54Z

src/nls/fa-ir/strings.js

    "GENERIC_ERROR"                     : "(خطا {0})",
    "NOT_FOUND_ERR"                     : "پرونده پیدا نشد.",
    "NOT_READABLE_ERR"                  : "پرونده قابل خواندن نیست.",
+    "EXCEEDS_MAX_FILE_SIZE"             : "فایل های بزرگتر از {0} MB قابل ویرایش  در {APP_NAME} نیست.",


add in brackets 1.0

RaymondLim · 2014-12-12T17:53:10Z

@datamweb Can you address or comment on line 93 that @mohammadyaghobi comment on?
@mohammadyaghobi Have you reviewed the Getting Started index.html page?

Whenever you're done with review or changes, can you add a comment with @RaymondLim, so that I'll get a notification. We may need to get this done today so that I can have it into the master branch today. Otherwise, you may have to resubmit a new pull request to release branch. Thanks to both of you for your contributions.

Fix: Change line 40. chenge line 93.

datamweb · 2014-12-12T18:12:06Z

src/nls/fa-ir/strings.js

    "CSS_QUICK_EDIT_NO_STYLESHEETS"        : "هیچ شیوه نامه ای-پرونده CSS- در پروژه شما وجود ندارد.<br>جهت تعریف قوائد CSS ابتدا یک پرونده شیوه نامه ایجاد کنید.",

    // Custom Viewers
-    "IMAGE_VIEWER_LARGEST_ICON" : "بزرگ تر",
+    "IMAGE_VIEWER_LARGEST_ICON"            : "بزرگ تر",


datamweb · 2014-12-12T18:30:53Z

src/nls/fa-ir/strings.js

    "NO_MODIFICATION_ALLOWED_ERR"       : "دایرکتوری هدف قابل ویرایش نیست.",
    "NO_MODIFICATION_ALLOWED_ERR_FILE"  : "دسترسی های تعریف شده برای شما اجازه تغییرات را نمی دهند.",
-    "CONTENTS_MODIFIED_ERR"             : "این پرونده قبل خارج از محیط این نرم افزار ویرایش شده است.",
+    "CONTENTS_MODIFIED_ERR"             : "فایل خارج از محیط {APP_NAME} تغییر یافته است.",


myaaghubi · 2014-12-12T19:38:41Z

@RaymondLim, yes, I've done it and I did not find any issues in translation
+1

RaymondLim · 2014-12-12T19:45:04Z

Ok, merging now.

For Farsi | Persian |فارسی l Language.

datamweb · 2014-12-12T19:56:15Z

Thanks to @mohammadyaghobi and @RaymondLim for your contributions.

datamweb added 6 commits December 2, 2014 22:34

Add Css

525d944

add RTL Css for Farsi | Persian |فارسی

Add Demo quick-edit for Farsi

50adc47

Image for farsiquick-edit

Updat for add Getting Start for Farsi | Persian | فارسی Language

5070478

Updet for add Getting Start for Farsi | Persian | فارسی Language

Revert "Full Farsi | Persian |فارسی translation for Brackts 1.0."

2467f38

This reverts commit 12892b5.

RaymondLim reviewed Dec 2, 2014
View reviewed changes

datamweb added 3 commits December 3, 2014 20:08

Update index.html

d5a22a9

Update strings.js

26430c6

fix white spaces and SHA.

Update strings.js

1d60964

for delete "APP_NAME" : "براکتس",

RaymondLim reviewed Dec 5, 2014
View reviewed changes

datamweb added 2 commits December 5, 2014 22:15

Update strings.js

cd2396f

fix SHA.

Update index.html

0047e46

fix SHA.

RaymondLim reviewed Dec 5, 2014
View reviewed changes

RaymondLim added the PR Triage Complete label Dec 5, 2014

RaymondLim reviewed Dec 5, 2014
View reviewed changes

datamweb added 3 commits December 5, 2014 23:21

Update index.html

5939b91

Update rtl_main.css

fa9db96

Update index.html

f7c498d

RaymondLim reviewed Dec 5, 2014
View reviewed changes

Update index.html

4201512

datamweb reviewed Dec 12, 2014
View reviewed changes

Update strings.js

91fbacd

Fix: Change line 40. chenge line 93.

datamweb reviewed Dec 12, 2014
View reviewed changes

Update index.html

8e4b283

datamweb reviewed Dec 12, 2014
View reviewed changes

Update strings.js

9b31590

RaymondLim added a commit that referenced this pull request Dec 12, 2014

Merge pull request #10062 from datamweb/master

c76533c

For Farsi | Persian |فارسی l Language.

RaymondLim merged commit c76533c into adobe:master Dec 12, 2014

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] For Farsi | Persian |فارسی l Language. brackets-archive/bracketsIssues#8932

Open

For Farsi | Persian |فارسی l Language. #10062

For Farsi | Persian |فارسی l Language. #10062

Uh oh!

Conversation

datamweb commented Dec 2, 2014

Uh oh!

busykai commented Dec 2, 2014

Uh oh!

datamweb commented Dec 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

busykai commented Dec 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datamweb commented Dec 5, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaymondLim commented Dec 5, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaymondLim commented Dec 12, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

myaaghubi commented Dec 12, 2014

Uh oh!

RaymondLim commented Dec 12, 2014

Uh oh!

datamweb commented Dec 12, 2014

Uh oh!

Uh oh!