You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TomMalbran:
It might be cleaner to just call run() so the code there that chooses the tooltip, icon color, etc. isn't duplicated here (which raises the possibility of future bugs similar to this one).
But actually, it looks like the initial _setEnabled() call from _prefs will always force a run() already. I think the problem is, because it happens before htmlReady, the UI isn't there to be updated yet. Do you want to try moving the _setEnabled() call into the htmlReady callback and see if that fixes it? (And do some testing to make sure it doesn't have any negative side effects).
If that works I think it's the cleanest fix. We should add a comment onto the _setEnabled() call saying it triggers the initial UI update, and then that's that.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #2270 and follow-up pull request of #2100