CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 00:00:10 GMT
content-length: 0
location: https://github.com/adobe/brackets/pull/2198
server-timing: nginx;desc="NGINX";dur=1.464277,glb;desc="GLB";dur=95.484336
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=YPfwPxlHcAK92hBZlbNN7zplANkbqmpFY0c%2FMCTwr6rhBin51Esa823LlAYVzzmRA8oRWTdFhKfL8iQtTZQT2YfaVeE%2Bgtw0wl%2F1F4Y8lk2kETiqVZ7s8aEITYJhJXjxvem653kvQuMNSRAo9r4XuHlWGCd6pj9JZOOd4S%2F%2FFAM2Apx7xLFe%2BtqtWzNl22j%2BS5dSRoEmbSSrWgxO9Xp84DlL%2BvvnANKyW8YkKKTJhje0BR5Tlrh2ucJcJ5ZS8Vs15AtoT6OqJ99GpwuHYmJQoA%3D%3D--CLxWuunMfLMOIy3r--135QRrQV17jnI%2F%2Fb1WLC6Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.216856819.1752537609; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 00:00:09 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 00:00:09 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B13A:23F0B0:1018F6:180E2C:68759A09
HTTP/2 200
date: Tue, 15 Jul 2025 00:00:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=369.103626,conversation_content-fragment;desc="conversation_content fragment";dur=464.226944,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=222.712726,nginx;desc="NGINX";dur=1.121987,glb;desc="GLB";dur=96.253943
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B13A:23F0B0:10190D:180E56:68759A09
Create files on collapsed folders (#2085) by jbalsas · Pull Request #2198 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Create files on collapsed folders (#2085) #2198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works great! Thanks for the fix. |
gruehle
added a commit
that referenced
this pull request
Dec 5, 2012
Create files on collapsed folders (#2085)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This is a possible fix for #2085 by waiting on the
open_node.jstree
event before trying to create a new node.It looks like we're hitting a strange race condition in
jsquery.jstree.js
which appears when the node we want to open hasn't been loaded yet.In that case,
open_node
triggers aload_node
in line 640.Almost at the same time, a different
load_node
is triggered from the CRRMcreate
throughcreate_node
in line 734Not digging much further, if the second
load_node
gets called because the first one is not completed, thencreate_node
is not called again as expected and nothing gets created. This can be tested by adding a breakpoint in line 733. Doing that, the firstload_node
always finishes and the function completes ok.By waiting to the
open_node
event, we're making sure we always step intocreate_node
once the node is already loaded.UPDATE Just to confirm, the
load_node_json
call just returns without doing nothing if the node is already being loaded, which causes the callback tocreate_node
to get dropped without ever being called. Also, this check seems to have been removed in the v1.0 branch (https://github.com/vakata/jstree/blob/v.1.0/src/jstree.json.js)