| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 14 Jul 2025 21:46:12 GMT
content-length: 0
location: https://github.com/adobe/brackets/pull/2158
server-timing: nginx;desc="NGINX";dur=0.934658,glb;desc="GLB";dur=95.91276
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=RJ4tG3F3lt6RTW%2FFtm1WAeEEtnqabkepyi4bsFg9yvwpnvIZmXbAW132yy%2FQL8nh6ef6GDB0bqvKthdnXDgJi6FuZH9qxpkfogLmj1pUJJhj%2FCz5JVcBnGOaz%2B6Wg29aipGHC92S9lrJIvUpJmG%2BvVZUQtahoAILVatyCqpyqyz9QFziMCxR0AsqPEQPFgnN%2FF%2BHQv4FTlY5TUXSTbjyzR%2Bl7gYj7xFD8ShQHkFVD1m5Y2m5KUMxoUL17tfRfp648oNNnrEq8aJOSYXdDx6KVg%3D%3D--2Zn23ABuYVlu4RUm--t69FBcEFk3R%2FlkdRH5NukA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.191846774.1752529572; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:46:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:46:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D252:3151B:8A7F9:C5DC2:68757AA4
HTTP/2 200
date: Mon, 14 Jul 2025 21:46:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=295.425185,conversation_content-fragment;desc="conversation_content fragment";dur=1875.227625,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=208.657214,nginx;desc="NGINX";dur=0.868229,glb;desc="GLB";dur=102.759187
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D252:3151B:8A816:C5DEB:68757AA4
FileSystem Implementation (#247) by jbalsas · Pull Request #2158 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Thanks, Chema. I'm not sure if we can prioritize this for this week. We'll have to take a look again next week. Thanks for your patience. |
|
No problem! It's lowprio/cleanup and you guys seem busy enough. No need to hurry on this one ;) |
|
reviewing |
| @@ -214,6 +214,7 @@ define(function (require, exports, module) { | |||
| // TODO: (issue #241): implement FileEntry.remove() | |||
| // once NativeFileSystem has a delete/unlink, should use that | |||
| brackets.fs.unlink(placeholderPath, function (err) { | |||
| console.log(err); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debug code
|
Initial review complete. Just one minor comment. |
|
Oops... fixed! |
|
Thanks, Chema! Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Dec 6, 2012
FileSystem Implementation (#247)
This was referenced Aug 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This pull request implements the
FileSysteminterface described in https://www.w3.org/TR/file-system-api/#the-filesystem-interface and modifiesNativeFileSystem.requestNativeFileSystemto return aFileSystemobject with a rootDirectoryEntryfollowing the specs.As indicated in #247, it also updates all existing calls to
requestNativeFileSystem(tests included) to get the root DirectoryEntry.This is a dangerous change that could potentially break several extensions so we may want to implement this in a more backward compatible manner. However, I've done a global find in all the extensions listed in the wiki and only brackets-snippets seems to be calling
requestNativeFileSystemdirectly, so it looks less disruptive than I originally thought...