| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 00:00:14 GMT
content-length: 0
location: https://github.com/adobe/brackets/pull/2063
server-timing: nginx;desc="NGINX";dur=1.048032,glb;desc="GLB";dur=95.65814
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=zI2KYxVeFZ7%2Bc6%2BKlYudkLJBzZXxhQ6ghxYarLmjnAbNdVLCQ%2B8eBdFFoBZBWkWai4NWFRTBeh9Jxq%2FeRzjWNmNPTlteU2K7oDjCiL5rVuKqaMqsTrm5Nepi5KbJATMG1vpUJaRWCimitbh6Joqd85WHURlYXtFbPrFD9PbL3A%2BiICM7CxTRSuPhxYIef5KNiQIQ0qcQwlMsMb2nQArDVD2v6yOmPUrc6IXMDMpO5LsCktM4SKbcqhK5Ef7KIEayVfNbTtlMRpEEPwWFjUkmBg%3D%3D--WdzQ4XR3GKcJy8m9--4%2Fafd7%2FxGB4By3BERuSunQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1055719779.1752537614; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 00:00:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 00:00:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B18A:B4F9F:10219E:181761:68759A0E
HTTP/2 200
date: Tue, 15 Jul 2025 00:00:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=315.295337,conversation_content-fragment;desc="conversation_content fragment";dur=978.012018,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=253.896567,nginx;desc="NGINX";dur=0.852001,glb;desc="GLB";dur=96.156976
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B18A:B4F9F:1021B5:181785:68759A0E
NativeFileSystem documentation and examples (#1052) by jbalsas · Pull Request #2063 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
NativeFileSystem documentation and examples (#1052) #2063
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
…ystem-doc Conflicts: src/file/NativeFileSystem.js
|
Assigned to me. @jbalsas Now that the other NativeFileSystem changes are merged, do you want to update this pull request or should I close this? |
|
Sure! Let me merge with master first and then review and update this before you take a look. |
…ystem-doc Conflicts: src/file/NativeFileSystem.js src/language/CSSUtils.js
|
@jasonsanjose Merged and updated. All yours ;) |
| * NativeFileSystem.DirectoryEntry().getDirectory(path, {create: true}); | ||
| * | ||
| * - CHECK IF A FILE OR FOLDER EXISTS | ||
| * NativeFileSystem.requestNativeFileSystem(path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think resolveNativeFileSystemPath is a more appropriate example. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense. This wasn't implemented by the time I added the examples, though. Will switch to resolveNativeFileSystemPath here.
| /** | ||
| * Copies this Entry to a different location on the file system. | ||
| * @param {!DirectoryEntry} parent The directory to copy the entry to | ||
| * @param {!string=} newName The new name of the entry. If not specified, defaults to the current name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove !
|
Initial review complete. Thanks for taking this one. |
|
@jasonsanjose I'll dive into this later today. Just need one clarification. From the Closure Compiler docs, Is it possible that we're using Furthermore, if we stick to the meaning of What do you think? |
|
Yep, we're using You're right that it seems redundant to add |
|
I think I've addressed all your comments. Ready for a second pass. |
|
Looks great. I filed #2360 to cover the incorrect annotations. Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Dec 14, 2012
NativeFileSystem documentation and examples (#1052)
This was referenced Aug 29, 2021
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Hi,
I was going through
NativeFileSystemthe other day and ran across #1052This pull request should address those concerns. Additionally, it removes some unused requires with NativeFileSystem.
As pointed out in #2058, some of the APIs are not consitent with the current specs. The jsdocs here reflect the specs, and would need to get updated with that information.