Merge pull request #3688 from jeffslofish/Issue3131-copyable-jslint-errors

redmunds · redmunds · commit d57cd7567c0c · 2013-05-10T09:36:29.000-07:00
Issue #3131 - Making JSLint errors copyable
diff --git a/src/extensions/default/JSLint/htmlContent/bottom-panel.html b/src/extensions/default/JSLint/htmlContent/bottom-panel.html
@@ -1,4 +1,4 @@
-<div id="jslint-results" class="bottom-panel vert-resizable top-resizer no-focus">
+<div id="jslint-results" class="bottom-panel vert-resizable top-resizer">
     <div class="toolbar simple-toolbar-layout">
         <div class="title">{{JSLINT_ERRORS}}</div>
     </div>
diff --git a/src/styles/brackets.less b/src/styles/brackets.less
@@ -48,12 +48,7 @@ html, body {
     overflow: hidden;
     
     /* Turn off selection for UI elements */
-    -webkit-user-select: none;
-    -khtml-user-select: none;
-    -moz-user-select: none;
-    -ms-user-select: none;
-    -o-user-select: none;
-    user-select: none;
+    .user-select(none);
     
     /* And make sure we get a pointer cursor even over text */
     cursor: default;
@@ -839,3 +834,8 @@ li.smart_autocomplete_highlight {
         background-size: 100%;
     }
 }
+
+/* Turn on text selection for JSLint error messages */
+#jslint-results {
+    .user-select(text);
+}
diff --git a/src/styles/brackets_mixins.less b/src/styles/brackets_mixins.less
@@ -118,3 +118,14 @@
     -o-transform-origin: @horizontal @vertical;
     transform-origin: @horizontal @vertical;
 }
+
+/* Change the settings for user-select and its counterparts, defaulting to none. */
+.user-select(@type: none) {
+    -webkit-user-select: @type;
+    -khtml-user-select: @type;
+    -moz-user-select: @type;
+    -ms-user-select: @type;
+    -o-user-select: @type;
+    user-select: @type;
+}
+
diff --git a/src/styles/brackets_patterns_override.less b/src/styles/brackets_patterns_override.less
@@ -442,12 +442,7 @@
             
             // Enable text selection
             cursor: auto;
-            -webkit-user-select: text;
-            -khtml-user-select: text;
-            -moz-user-select: text;
-            -ms-user-select: text;
-            -o-user-select: text;
-            user-select: text;
+            .user-select(text);
         }
     }
 }
@@ -564,12 +559,7 @@
         
         // Enable text selection
         cursor: auto;
-        -webkit-user-select: text;
-        -khtml-user-select: text;
-        -moz-user-select: text;
-        -ms-user-select: text;
-        -o-user-select: text;
-        user-select: text;
+        .user-select(text);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<div id="jslint-results" class="bottom-panel vert-resizable top-resizer no-focus">`
	`1`	`+<div id="jslint-results" class="bottom-panel vert-resizable top-resizer">`
`2`	`2`	`<div class="toolbar simple-toolbar-layout">`
`3`	`3`	`<div class="title">{{JSLINT_ERRORS}}</div>`
`4`	`4`	`</div>`
Original file line number	Diff line number	Diff line change
`@@ -442,12 +442,7 @@`
`442`	`442`
`443`	`443`	`// Enable text selection`
`444`	`444`	`cursor: auto;`
`445`		`- -webkit-user-select: text;`
`446`		`- -khtml-user-select: text;`
`447`		`- -moz-user-select: text;`
`448`		`- -ms-user-select: text;`
`449`		`- -o-user-select: text;`
`450`		`- user-select: text;`
	`445`	`+ .user-select(text);`
`451`	`446`	`}`
`452`	`447`	`}`
`453`	`448`	`}`
`@@ -564,12 +559,7 @@`
`564`	`559`
`565`	`560`	`// Enable text selection`
`566`	`561`	`cursor: auto;`
`567`		`- -webkit-user-select: text;`
`568`		`- -khtml-user-select: text;`
`569`		`- -moz-user-select: text;`
`570`		`- -ms-user-select: text;`
`571`		`- -o-user-select: text;`
`572`		`- user-select: text;`
	`562`	`+ .user-select(text);`
`573`	`563`	`}`
`574`	`564`	`}`
`575`	`565`