Fix lgtm alerts (#13483)

max-schaefer · petetnt · commit bc14a9e9a435 · 2017-07-08T22:20:22.000+03:00
* Simplify a regular expression.

The previous regexp looked a little dubious, since `[\\\\]` means exactly the same as `[\\]`. Note, however, that `/x*y/.test(s)` returns true iff `/y/.test(s)` does, so the character class was redundant to begin with.

* Remove a few spurious trailing arguments.

* Remove a few unused local variables.
diff --git a/src/LiveDevelopment/MultiBrowserImpl/language/HTMLSimpleDOM.js b/src/LiveDevelopment/MultiBrowserImpl/language/HTMLSimpleDOM.js
@@ -266,7 +266,7 @@ define(function (require, exports, module) {
      */
     Builder.prototype.build = function (strict, markCache) {
         var self = this;
-        var token, lastClosedTag, lastTextNode, lastIndex = 0;
+        var token, lastClosedTag, lastTextNode;
         var stack = this.stack;
         var attributeName = null;
         var nodeMap = {};
@@ -441,7 +441,6 @@ define(function (require, exports, module) {
                     newNode.update();
                 }
             }
-            lastIndex = token.end;
         }
 
         // If we have any tags hanging open (e.g. html or body), fail the parse if we're in strict mode,
diff --git a/src/command/Menus.js b/src/command/Menus.js
@@ -675,7 +675,7 @@ define(function (require, exports, module) {
             KeyBindingManager.addBinding(commandID, keyBindings);
 
             // Look for existing key bindings
-            _addExistingKeyBinding(menuItem, commandID);
+            _addExistingKeyBinding(menuItem);
 
             menuItem._checkedChanged();
             menuItem._enabledChanged();
diff --git a/src/extensibility/node/ExtensionManagerDomain.js b/src/extensibility/node/ExtensionManagerDomain.js
@@ -236,7 +236,7 @@ function _cmdInstall(packagePath, destinationDirectory, options, callback, pCall
         // If there was trouble at the validation stage, we stop right away.
         if (err || validationResult.errors.length > 0) {
             validationResult.installationStatus = Statuses.FAILED;
-            deleteTempAndCallback(err, validationResult);
+            deleteTempAndCallback(err);
             return;
         }
 
@@ -287,7 +287,7 @@ function _cmdInstall(packagePath, destinationDirectory, options, callback, pCall
                     // both legacy and new extensions installed.
                     fs.remove(legacyDirectory, function (err) {
                         if (err) {
-                            deleteTempAndCallback(err, validationResult);
+                            deleteTempAndCallback(err);
                             return;
                         }
                         _removeAndInstall(packagePath, installDirectory, validationResult, deleteTempAndCallback);
@@ -298,7 +298,7 @@ function _cmdInstall(packagePath, destinationDirectory, options, callback, pCall
             } else if (hasLegacyPackage) {
                 validationResult.installationStatus = Statuses.NEEDS_UPDATE;
                 validationResult.name = guessedName;
-                deleteTempAndCallback(null, validationResult);
+                deleteTempAndCallback(null);
             } else {
                 _checkExistingInstallation(validationResult, installDirectory, systemInstallDirectory, deleteTempAndCallback);
             }
diff --git a/src/extensions/default/JavaScriptCodeHints/HintUtils.js b/src/extensions/default/JavaScriptCodeHints/HintUtils.js
@@ -145,7 +145,7 @@ define(function (require, exports, module) {
             t.kind = kind;
             t.origin = "ecmascript";
             if (kind === "string") {
-                if (/[\\\\]*[^\\]"/.test(t.value)) {
+                if (/[^\\]"/.test(t.value)) {
                     t.delimiter = SINGLE_QUOTE;
                 } else {
                     t.delimiter = DOUBLE_QUOTE;
diff --git a/src/extensions/default/JavaScriptCodeHints/Session.js b/src/extensions/default/JavaScriptCodeHints/Session.js
@@ -464,13 +464,9 @@ define(function (require, exports, module) {
         var propertyLookup   = false,
             context          = null,
             cursor           = this.getCursor(),
-            token            = this.getToken(cursor),
-            lexical;
+            token            = this.getToken(cursor);
 
         if (token) {
-            // if this token is part of a function call, then the tokens lexical info
-            // will be annotated with "call"
-            lexical = getLexicalState(token);
             if (token.type === "property") {
                 propertyLookup = true;
             }
diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
@@ -643,7 +643,7 @@ define(function (require, exports, module) {
         }
         
         if (_isInPropName(ctx)) {
-            return _getPropNameInfo(ctx, ctx.editor);
+            return _getPropNameInfo(ctx);
         }
         
         if (_isInPropValue(ctx)) {
diff --git a/src/language/HTMLSimpleDOM.js b/src/language/HTMLSimpleDOM.js
@@ -301,7 +301,7 @@ define(function (require, exports, module) {
      */
     Builder.prototype.build = function (strict, markCache) {
         var self = this;
-        var token, lastClosedTag, lastTextNode, lastIndex = 0;
+        var token, lastClosedTag, lastTextNode;
         var stack = this.stack;
         var attributeName = null;
         var nodeMap = {};
@@ -479,7 +479,6 @@ define(function (require, exports, module) {
                     newNode.update();
                 }
             }
-            lastIndex = token.end;
         }
 
         // If we have any tags hanging open, fail the parse if we're in strict mode,
diff --git a/src/project/WorkingSetView.js b/src/project/WorkingSetView.js
@@ -334,7 +334,6 @@ define(function (require, exports, module) {
                     gTop,
                     gHeight,
                     gBottom,
-                    deltaY,
                     containerOffset,
                     scrollerTopArea,
                     scrollerBottomArea;
@@ -409,7 +408,6 @@ define(function (require, exports, module) {
                 gTop = $ghost.offset().top;
                 gHeight = $ghost.height();
                 gBottom = gTop + gHeight;
-                deltaY = pageY - e.pageY;
 
                 // data to help us determine if we have a scroller
                 hasScroller = $item.length && $container.length && $container[0].scrollHeight > $container[0].clientHeight;
diff --git a/src/widgets/bootstrap-scrollspy.js b/src/widgets/bootstrap-scrollspy.js
@@ -46,12 +46,11 @@
 
     , refresh: function () {
         var self = this
-          , $targets
 
         this.offsets = $([])
         this.targets = $([])
 
-        $targets = this.$body
+        this.$body
           .find(this.selector)
           .map(function () {
             var $el = $(this)
diff --git a/src/widgets/bootstrap-tooltip.js b/src/widgets/bootstrap-tooltip.js
@@ -115,7 +115,6 @@
       var $tip
         , pos
         , actualWidth
-        , actualHeight
         , placement
         , tp
         , e = $.Event('show')
@@ -143,7 +142,6 @@
         pos = this.getPosition()
 
         actualWidth = $tip[0].offsetWidth
-        actualHeight = $tip[0].offsetHeight
 
         switch (placement) {
           case 'bottom':

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ define(function (require, exports, module) {`
`266`	`266`	`*/`
`267`	`267`	`Builder.prototype.build = function (strict, markCache) {`
`268`	`268`	`var self = this;`
`269`		`- var token, lastClosedTag, lastTextNode, lastIndex = 0;`
	`269`	`+ var token, lastClosedTag, lastTextNode;`
`270`	`270`	`var stack = this.stack;`
`271`	`271`	`var attributeName = null;`
`272`	`272`	`var nodeMap = {};`
`@@ -441,7 +441,6 @@ define(function (require, exports, module) {`
`441`	`441`	`newNode.update();`
`442`	`442`	`}`
`443`	`443`	`}`
`444`		`- lastIndex = token.end;`
`445`	`444`	`}`
`446`	`445`
`447`	`446`	`// If we have any tags hanging open (e.g. html or body), fail the parse if we're in strict mode,`
Original file line number	Diff line number	Diff line change
`@@ -643,7 +643,7 @@ define(function (require, exports, module) {`
`643`	`643`	`}`
`644`	`644`
`645`	`645`	`if (_isInPropName(ctx)) {`
`646`		`- return _getPropNameInfo(ctx, ctx.editor);`
	`646`	`+ return _getPropNameInfo(ctx);`
`647`	`647`	`}`
`648`	`648`
`649`	`649`	`if (_isInPropValue(ctx)) {`
Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ define(function (require, exports, module) {`
`301`	`301`	`*/`
`302`	`302`	`Builder.prototype.build = function (strict, markCache) {`
`303`	`303`	`var self = this;`
`304`		`- var token, lastClosedTag, lastTextNode, lastIndex = 0;`
	`304`	`+ var token, lastClosedTag, lastTextNode;`
`305`	`305`	`var stack = this.stack;`
`306`	`306`	`var attributeName = null;`
`307`	`307`	`var nodeMap = {};`
`@@ -479,7 +479,6 @@ define(function (require, exports, module) {`
`479`	`479`	`newNode.update();`
`480`	`480`	`}`
`481`	`481`	`}`
`482`		`- lastIndex = token.end;`
`483`	`482`	`}`
`484`	`483`
`485`	`484`	`// If we have any tags hanging open, fail the parse if we're in strict mode,`