Bux fixed : clicking several times on the update notification icon opened multiple notification dialogs (#12921)

bokub · petetnt · commit acd0dd0b7ca2 · 2016-11-27T16:52:55.000+02:00
diff --git a/src/utils/UpdateNotification.js b/src/utils/UpdateNotification.js
@@ -259,6 +259,9 @@ define(function (require, exports, module) {
         var $dlg        = $(".update-dialog.instance"),
             $updateList = $dlg.find(".update-info");
 
+        // Make the update notification icon clickable again
+        _addedClickHandler = false;
+
         updates.Strings = Strings;
         $updateList.html(Mustache.render(UpdateListTemplate, updates));
     }
@@ -370,12 +373,14 @@ define(function (require, exports, module) {
                     var $updateNotification = $("#update-notification");
 
                     $updateNotification.css("display", "block");
-                    if (!_addedClickHandler) {
-                        _addedClickHandler = true;
-                        $updateNotification.on("click", function () {
+
+                    $updateNotification.on("click", function () {
+                        // Block the click until the Notification Dialog opens
+                        if (!_addedClickHandler) {
+                            _addedClickHandler = true;
                             checkForUpdate(true);
-                        });
-                    }
+                        }
+                    });
 
                     // Only show the update dialog if force = true, or if the user hasn't been
                     // alerted of this update
