Fix for "GetItNow" action behaviour (#14691)

swmitra · shubhsnov · commit a408323d4a48 · 2019-04-09T23:42:12.000+05:30
* Fix for "GetItNow" action behaviour

Fix for "GetItNow" action behaviour

* Change variable success to initSuccess 

Make the variable name more explicit to depict it's to track update process initialisation success and not the success status of update process itself.
diff --git a/src/extensions/default/AutoUpdate/main.js b/src/extensions/default/AutoUpdate/main.js
@@ -483,6 +483,9 @@ define(function (require, exports, module) {
 
             //Initiate the auto update, with update params
             initiateAutoUpdate(updateParams);
+	    
+	    //Send a truthy value to ensure caller is informed about successful initialization of auto-update
+	    return true;
     }
 
 
diff --git a/src/utils/UpdateNotification.js b/src/utils/UpdateNotification.js
@@ -522,8 +522,8 @@ define(function (require, exports, module) {
      */
     function handleUpdateProcess(updates) {
         var handler = _updateProcessHandler || _defaultUpdateProcessHandler;
-        var success = handler(updates);
-        if (_updateProcessHandler && !success) {
+        var initSuccess = handler(updates);
+        if (_updateProcessHandler && !initSuccess) {
             // Give a chance to default handler in case
             // the auot update mechanism has failed.
             _defaultUpdateProcessHandler(updates);

Original file line number	Diff line number	Diff line change
`@@ -483,6 +483,9 @@ define(function (require, exports, module) {`
`483`	`483`
`484`	`484`	`//Initiate the auto update, with update params`
`485`	`485`	`initiateAutoUpdate(updateParams);`
	`486`	`+`
	`487`	`+ //Send a truthy value to ensure caller is informed about successful initialization of auto-update`
	`488`	`+ return true;`
`486`	`489`	`}`
`487`	`490`
`488`	`491`