Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

nethip · swmitra · commit 7479c0356fc5 · 2018-12-03T11:34:51.000+05:30
diff --git a/src/extensions/default/AutoUpdate/main.js b/src/extensions/default/AutoUpdate/main.js
@@ -486,12 +486,12 @@ define(function (require, exports, module) {
 
             } else {
                 // Update not present for current platform
-                return;
+                return false;
             }
 
             if (!checksum || !downloadURL || !installerName) {
                 console.warn("AutoUpdate : asset information incorrect for the update");
-                return;
+                return false;
             }
 
             var updateParams = {
diff --git a/src/utils/UpdateNotification.js b/src/utils/UpdateNotification.js
@@ -512,7 +512,12 @@ define(function (require, exports, module) {
      */
     function handleUpdateProcess(updates) {
         var handler = _updateProcessHandler || _defaultUpdateProcessHandler;
-        handler(updates);
+        var success = handler(updates);
+        if (_updateProcessHandler && !success) {
+            // Give a chance to default handler in case
+            // the auot update mechanism has failed.
+            _defaultUpdateProcessHandler(updates);
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -486,12 +486,12 @@ define(function (require, exports, module) {`
`486`	`486`
`487`	`487`	`} else {`
`488`	`488`	`// Update not present for current platform`
`489`		`- return;`
	`489`	`+ return false;`
`490`	`490`	`}`
`491`	`491`
`492`	`492`	`if (!checksum \|\| !downloadURL \|\| !installerName) {`
`493`	`493`	`console.warn("AutoUpdate : asset information incorrect for the update");`
`494`		`- return;`
	`494`	`+ return false;`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`var updateParams = {`