Merge pull request #9488 from TuurDutoit/deps-rewrite

ingorichter · ingorichter · commit 49d118f4a892 · 2014-10-14T14:59:05.000-07:00
dependencies.js rewrite
diff --git a/src/dependencies.js b/src/dependencies.js
@@ -29,26 +29,25 @@
  */
 window.setTimeout(function () {
     "use strict";
+    
+    var key, missingDeps = "";
     var deps = { "Mustache": window.Mustache, "jQuery": window.$, "RequireJS": window.require };
-    var key, missingDeps = [];
+    
     for (key in deps) {
         if (deps.hasOwnProperty(key) && !deps[key]) {
-            missingDeps.push(key);
+            missingDeps += "<li>" + key + "</li>";
         }
     }
-    if (missingDeps.length === 0) {
-        return;
+    
+    if (missingDeps.length > 0) {
+        var str = "<h1>Missing libraries</h1>" +
+                  "<p>Oops! One or more required libraries could not be found.</p>" +
+                  "<ul>" + missingDeps + "</ul>" +
+                  "<p>If you're running from a local copy of the Brackets source, please make sure submodules are updated by running:</p>" +
+                  "<pre>git submodule update --init</pre>" +
+                  "<p>If you're still having problems, please contact us via one of the channels mentioned at the bottom of the <a target=\"blank\" href=\"../README.md\">README</a>.</p>" +
+                  "<p><a href=\"#\" onclick=\"window.location.reload()\">Reload Brackets</a></p>";
+        
+        document.write(str);
     }
-    document.write("<h1>Missing libraries</h1>");
-    document.write("<p>Oops! One or more required libraries could not be found.</p>");
-    document.write("<ul>");
-    missingDeps.forEach(function (key) {
-        document.write("<li>" + key + "</li>");
-    });
-
-    document.write("</ul>");
-    document.write("<p>If you're running from a local copy of the Brackets source, please make sure submodules are updated by running:</p>");
-    document.write("<pre>git submodule update --init</pre>");
-    document.write("<p>If you're still having problems, please contact us via one of the channels mentioned at the bottom of the <a target=\"blank\" href=\"../README.md\">README</a>.</p>");
-    document.write("<p><a href=\"#\" onclick=\"window.location.reload()\">Reload Brackets</a></p>");
-}, 1000);
+}, 1000);
