Merge pull request #3297 from lkcampbell/fix-issue-1187

redmunds · redmunds · commit 3d4352aeff20 · 2013-05-15T16:10:26.000-07:00
Add/expose isVisibile, show, and hide methods for SidebarView object
diff --git a/src/project/SidebarView.js b/src/project/SidebarView.js
@@ -75,10 +75,32 @@ define(function (require, exports, module) {
     /**
      * Toggle sidebar visibility.
      */
-    function toggleSidebar(width) {
+    function toggle() {
         Resizer.toggle($sidebar);
     }
 
+    /**
+     * Show the sidebar.
+     */
+    function show() {
+        Resizer.show($sidebar);
+    }
+    
+    /**
+     * Hide the sidebar.
+     */
+    function hide() {
+        Resizer.hide($sidebar);
+    }
+    
+    /**
+     * Returns the visibility state of the sidebar.
+     * @return {boolean} true if element is visible, false if it is not visible
+     */
+    function visible() {
+        return Resizer.visible($sidebar);
+    }
+    
     // Initialize items dependent on HTML DOM
     AppInit.htmlReady(function () {
         $sidebar                = $("#sidebar");
@@ -129,8 +151,11 @@ define(function (require, exports, module) {
     });
     
     $(ProjectManager).on("projectOpen", _updateProjectTitle);
-    CommandManager.register(Strings.CMD_HIDE_SIDEBAR,       Commands.VIEW_HIDE_SIDEBAR,     toggleSidebar);
+    CommandManager.register(Strings.CMD_HIDE_SIDEBAR, Commands.VIEW_HIDE_SIDEBAR, toggle);
     
     // Define public API
-    exports.toggleSidebar = toggleSidebar;
+    exports.toggle  = toggle;
+    exports.show    = show;
+    exports.hide    = hide;
+    exports.visible = visible;
 });
diff --git a/src/utils/Resizer.js b/src/utils/Resizer.js
@@ -106,6 +106,15 @@ define(function (require, exports, module) {
         }
     }
     
+    /**
+     * Returns the visibility state of a resizable element.
+     * @param {DOMNode} element Html element to toggle
+     * @return {boolean} true if element is visible, false if it is not visible
+     */
+    function visible(element) {
+        return $(element).is(":visible");
+    }
+    
     /**
      * Adds resizing capabilities to a given html element.
      *
@@ -428,10 +437,11 @@ define(function (require, exports, module) {
         });
     });
     
-    exports.makeResizable        = makeResizable;
-    exports.toggle               = toggle;
-    exports.show                 = show;
-    exports.hide                 = hide;
+    exports.makeResizable   = makeResizable;
+    exports.toggle          = toggle;
+    exports.show            = show;
+    exports.hide            = hide;
+    exports.visible         = visible;
     
     //Resizer Constants
     exports.DIRECTION_VERTICAL   = DIRECTION_VERTICAL;
