Fix to avoid window location change confirmation dialog while running tests - onbeforeunload conditional registration (#14169)

swmitra · nethip · commit 2d65a3ccb173 · 2018-04-09T15:46:17.000+05:30
* onunload conditional registration

* Remove unused code
diff --git a/src/document/DocumentCommandHandlers.js b/src/document/DocumentCommandHandlers.js
@@ -1722,28 +1722,29 @@ define(function (require, exports, module) {
     /**
      * Attach a beforeunload handler to notify user about unsaved changes and URL redirection in CEF.
      * Prevents data loss in scenario reported under #13708
+     * Make sure we don't attach this handler if the current window is actually a test window
     **/
-    window.onbeforeunload = function(e) {
-        if (window.location.pathname.indexOf('SpecRunner') > -1) {
-            return;
-        }
 
-        var openDocs = DocumentManager.getAllOpenDocuments();
+    var isTestWindow = (new window.URLSearchParams(window.location.search || "")).get("testEnvironment");
+    if (!isTestWindow) {
+        window.onbeforeunload = function(e) {
+            var openDocs = DocumentManager.getAllOpenDocuments();
 
-        // Detect any unsaved changes
-        openDocs = openDocs.filter(function(doc) {
-            return doc && doc.isDirty;
-        });
+            // Detect any unsaved changes
+            openDocs = openDocs.filter(function(doc) {
+                return doc && doc.isDirty;
+            });
 
-        // Ensure we are not in normal app-quit or reload workflow
-        if (!_isReloading && !_windowGoingAway) {
-            if (openDocs.length > 0) {
-                return Strings.WINDOW_UNLOAD_WARNING_WITH_UNSAVED_CHANGES;
-            } else {
-                return Strings.WINDOW_UNLOAD_WARNING;
+            // Ensure we are not in normal app-quit or reload workflow
+            if (!_isReloading && !_windowGoingAway) {
+                if (openDocs.length > 0) {
+                    return Strings.WINDOW_UNLOAD_WARNING_WITH_UNSAVED_CHANGES;
+                } else {
+                    return Strings.WINDOW_UNLOAD_WARNING;
+                }
             }
-        }
-    };
+        };
+    }
 
     /** Do some initialization when the DOM is ready **/
     AppInit.htmlReady(function () {
