Merge pull request #11197 from adobe/marcel/define-preferences

abose · abose · commit 254927fa7855 · 2015-06-02T20:17:01.000+05:30
Define all preferences in core
diff --git a/src/extensions/default/CSSCodeHints/main.js b/src/extensions/default/CSSCodeHints/main.js
@@ -27,17 +27,21 @@
 define(function (require, exports, module) {
     "use strict";
 
-    var AppInit         = brackets.getModule("utils/AppInit"),
-        ExtensionUtils  = brackets.getModule("utils/ExtensionUtils"),
-        CodeHintManager = brackets.getModule("editor/CodeHintManager"),
-        CSSUtils        = brackets.getModule("language/CSSUtils"),
-        HTMLUtils       = brackets.getModule("language/HTMLUtils"),
-        LanguageManager = brackets.getModule("language/LanguageManager"),
-        TokenUtils      = brackets.getModule("utils/TokenUtils"),
-        StringMatch     = brackets.getModule("utils/StringMatch"),
-        ColorUtils      = brackets.getModule("utils/ColorUtils"),
-        CSSProperties   = require("text!CSSProperties.json"),
-        properties      = JSON.parse(CSSProperties);
+    var AppInit             = brackets.getModule("utils/AppInit"),
+        ExtensionUtils      = brackets.getModule("utils/ExtensionUtils"),
+        CodeHintManager     = brackets.getModule("editor/CodeHintManager"),
+        CSSUtils            = brackets.getModule("language/CSSUtils"),
+        HTMLUtils           = brackets.getModule("language/HTMLUtils"),
+        LanguageManager     = brackets.getModule("language/LanguageManager"),
+        PreferencesManager  = brackets.getModule("preferences/PreferencesManager"),
+        TokenUtils          = brackets.getModule("utils/TokenUtils"),
+        StringMatch         = brackets.getModule("utils/StringMatch"),
+        ColorUtils          = brackets.getModule("utils/ColorUtils"),
+        CSSProperties       = require("text!CSSProperties.json"),
+        properties          = JSON.parse(CSSProperties);
+
+
+    PreferencesManager.definePreference("codehint.CssPropHints", "boolean", true);
     
     // Context of the last request for hints: either CSSUtils.PROP_NAME,
     // CSSUtils.PROP_VALUE or null.
diff --git a/src/extensions/default/HTMLCodeHints/main.js b/src/extensions/default/HTMLCodeHints/main.js
@@ -32,11 +32,17 @@ define(function (require, exports, module) {
     var AppInit             = brackets.getModule("utils/AppInit"),
         CodeHintManager     = brackets.getModule("editor/CodeHintManager"),
         HTMLUtils           = brackets.getModule("language/HTMLUtils"),
+        PreferencesManager  = brackets.getModule("preferences/PreferencesManager"),
         HTMLTags            = require("text!HtmlTags.json"),
         HTMLAttributes      = require("text!HtmlAttributes.json"),
         tags,
         attributes;
 
+
+    PreferencesManager.definePreference("codehint.TagHints", "boolean", true);
+
+    PreferencesManager.definePreference("codehint.AttrHints", "boolean", true);
+
     /**
      * @constructor
      */
diff --git a/src/extensions/default/HtmlEntityCodeHints/main.js b/src/extensions/default/HtmlEntityCodeHints/main.js
@@ -33,9 +33,13 @@ define(function (require, exports, module) {
         CodeHintManager     = brackets.getModule("editor/CodeHintManager"),
         ExtensionUtils      = brackets.getModule("utils/ExtensionUtils"),
         HTMLUtils           = brackets.getModule("language/HTMLUtils"),
+        PreferencesManager  = brackets.getModule("preferences/PreferencesManager"),
         HtmlSpecialChars    = require("text!SpecialChars.json"),
         specialChars;
 
+
+    PreferencesManager.definePreference("codehint.SpecialCharHints", "boolean", true);
+
     /**
      * Encodes the special Char value given. 
      * 
@@ -271,4 +275,4 @@ define(function (require, exports, module) {
     
     //Export Hints for Unit Tests
     exports.SpecialCharHints = SpecialCharHints;
-});
+});
diff --git a/src/extensions/default/StaticServer/StaticServer.js b/src/extensions/default/StaticServer/StaticServer.js
@@ -41,6 +41,8 @@ define(function (require, exports, module) {
      */
     var _prefs = PreferencesManager.getExtensionPrefs("staticserver");
 
+    _prefs.definePreference("port", "number", 0);
+
     /**
      * @constructor
      * @extends {BaseServer}
diff --git a/src/extensions/default/UrlCodeHints/main.js b/src/extensions/default/UrlCodeHints/main.js
@@ -28,22 +28,26 @@ define(function (require, exports, module) {
     "use strict";
     
     // Brackets modules
-    var AppInit         = brackets.getModule("utils/AppInit"),
-        CodeHintManager = brackets.getModule("editor/CodeHintManager"),
-        CSSUtils        = brackets.getModule("language/CSSUtils"),
-        FileSystem      = brackets.getModule("filesystem/FileSystem"),
-        FileUtils       = brackets.getModule("file/FileUtils"),
-        HTMLUtils       = brackets.getModule("language/HTMLUtils"),
-        ProjectManager  = brackets.getModule("project/ProjectManager"),
-        StringUtils     = brackets.getModule("utils/StringUtils"),
+    var AppInit             = brackets.getModule("utils/AppInit"),
+        CodeHintManager     = brackets.getModule("editor/CodeHintManager"),
+        CSSUtils            = brackets.getModule("language/CSSUtils"),
+        FileSystem          = brackets.getModule("filesystem/FileSystem"),
+        FileUtils           = brackets.getModule("file/FileUtils"),
+        HTMLUtils           = brackets.getModule("language/HTMLUtils"),
+        PreferencesManager  = brackets.getModule("preferences/PreferencesManager"),
+        ProjectManager      = brackets.getModule("project/ProjectManager"),
+        StringUtils         = brackets.getModule("utils/StringUtils"),
 
         Data            = require("text!data.json"),
 
         urlHints,
         data,
         htmlAttrs,
         styleModes      = ["css", "text/x-less", "text/x-scss"];
-    
+
+
+    PreferencesManager.definePreference("codehint.UrlCodeHints", "boolean", true);
+
     /**
      * @constructor
      */
diff --git a/src/language/CodeInspection.js b/src/language/CodeInspection.js
@@ -609,7 +609,11 @@ define(function (require, exports, module) {
         });
     
     prefs.definePreference(PREF_ASYNC_TIMEOUT, "number", 10000);
-        
+
+    prefs.definePreference(PREF_PREFER_PROVIDERS, "array", []);
+
+    prefs.definePreference(PREF_PREFERRED_ONLY, "boolean", false);
+
     // Initialize items dependent on HTML DOM
     AppInit.htmlReady(function () {
         // Create bottom panel to list error details
