Merge pull request #11641 from ficristo/remember-linter-collapsed

abose · abose · commit 0b946f79aef5 · 2015-09-11T15:26:16.000+01:00
Remember linter collapsed
diff --git a/src/htmlContent/problems-panel-table.html b/src/htmlContent/problems-panel-table.html
@@ -2,10 +2,14 @@
     <tbody>
         {{#reportList}}
         <tr class="inspector-section">
-            <td colspan="3"><span class="disclosure-triangle expanded"></span>{{providerName}} ({{results.length}})</td>
+            <td colspan="3">
+                <span class="disclosure-triangle {{#isExpanded}}expanded{{/isExpanded}}"></span>
+                <input type="hidden" value="{{providerName}}" />
+                {{providerName}} ({{results.length}})
+            </td>
         </tr>
         {{#results}}
-        <tr>
+        <tr class="{{display}}">
             <td class="line-number" data-character="{{pos.ch}}">{{friendlyLine}}</td>
             <td class="line-text">{{message}}</td>
             <td class="line-snippet">{{codeSnippet}}</td>
diff --git a/src/language/CodeInspection.js b/src/language/CodeInspection.js
@@ -414,6 +414,7 @@ define(function (require, exports, module) {
                 // Augment error objects with additional fields needed by Mustache template
                 results.forEach(function (inspectionResult) {
                     var provider = inspectionResult.provider;
+                    var isExpanded = prefs.get(provider.name + ".collapsed") !== false;
 
                     if (inspectionResult.result) {
                         inspectionResult.result.errors.forEach(function (error) {
@@ -428,6 +429,9 @@ define(function (require, exports, module) {
                             if (error.type !== Type.META) {
                                 numProblems++;
                             }
+                            
+                            // Hide the errors when the provider is collapsed.
+                            error.display = isExpanded ? "" : "forced-hidden";
                         });
 
                         // if the code inspector was unable to process the whole file, we keep track to show a different status
@@ -437,6 +441,7 @@ define(function (require, exports, module) {
 
                         if (inspectionResult.result.errors.length) {
                             allErrors.push({
+                                isExpanded:   isExpanded,
                                 providerName: provider.name,
                                 results:      inspectionResult.result.errors
                             });
@@ -655,11 +660,20 @@ define(function (require, exports, module) {
 
                 // This is a inspector title row, expand/collapse on click
                 if ($selectedRow.hasClass("inspector-section")) {
-                    // Clicking the inspector title section header collapses/expands result rows
-                    $selectedRow.nextUntil(".inspector-section").toggle();
-
                     var $triangle = $(".disclosure-triangle", $selectedRow);
+                    var isExpanded = $triangle.hasClass("expanded");
+
+                    // Clicking the inspector title section header collapses/expands result rows
+                    if (isExpanded) {
+                        $selectedRow.nextUntil(".inspector-section").addClass("forced-hidden");
+                    } else {
+                        $selectedRow.nextUntil(".inspector-section").removeClass("forced-hidden");
+                    }
                     $triangle.toggleClass("expanded");
+
+                    var providerName = $selectedRow.find("input[type='hidden']").val();
+                    prefs.set(providerName + ".collapsed", !isExpanded);
+                    prefs.save();
                 } else {
                     // This is a problem marker row, show the result on click
                     // Grab the required position data
