You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this PR change? What problem does it solve?
This PR adds label.iconSVG key under site params. It can be used to embed the SVG directly for easier styling, e.g. for handling the change between dark and light mode.
Was the change discussed in an issue or in the Discussions before? Closes#974.
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean for it to come across as a complaint.
I was just looking for a confirmation on the matter to proceed with the PR.
I had already said we can go ahead in discord. Anyways about the svg height, we don't need to implement that.
It is redundant to add iconHeight to replace height in svg. User can add height directly in svg.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR adds
label.iconSVG
key under site params. It can be used to embed the SVG directly for easier styling, e.g. for handling the change between dark and light mode.Was the change discussed in an issue or in the Discussions before?
Closes #974.
PR Checklist