Remove deprecated symbol absl::kuint128max

derekmauro · copybara-github · commit 34604d5b1f6a · 2024-02-12T09:45:21.000-08:00
absl::kuint128max should be replaced with absl::Uint128Max()
PiperOrigin-RevId: 606279299
Change-Id: Ib67b5431f14891f56bb706e62f183d0de75d335f
diff --git a/absl/numeric/int128.cc b/absl/numeric/int128.cc
@@ -29,9 +29,6 @@
 namespace absl {
 ABSL_NAMESPACE_BEGIN
 
-ABSL_DLL const uint128 kuint128max = MakeUint128(
-    std::numeric_limits<uint64_t>::max(), std::numeric_limits<uint64_t>::max());
-
 namespace {
 
 // Returns the 0-based position of the last set bit (i.e., most significant bit)
diff --git a/absl/numeric/int128.h b/absl/numeric/int128.h
@@ -244,11 +244,6 @@ class
 #endif  // byte order
 };
 
-// Prefer to use the constexpr `Uint128Max()`.
-//
-// TODO(absl-team) deprecate kuint128max once migration tool is released.
-ABSL_DLL extern const uint128 kuint128max;
-
 // allow uint128 to be logged
 std::ostream& operator<<(std::ostream& os, uint128 v);
 
diff --git a/absl/numeric/int128_stream_test.cc b/absl/numeric/int128_stream_test.cc
@@ -135,11 +135,11 @@ TEST(Uint128, OStreamValueTest) {
                     "2000000000000000000000000000000000000000000"});
   CheckUint128Case({absl::MakeUint128(0x8000000000000000, 0), kHex,
                     /*width = */ 0, "80000000000000000000000000000000"});
-  CheckUint128Case({absl::kuint128max, kDec, /*width = */ 0,
+  CheckUint128Case({absl::Uint128Max(), kDec, /*width = */ 0,
                     "340282366920938463463374607431768211455"});
-  CheckUint128Case({absl::kuint128max, kOct, /*width = */ 0,
+  CheckUint128Case({absl::Uint128Max(), kOct, /*width = */ 0,
                     "3777777777777777777777777777777777777777777"});
-  CheckUint128Case({absl::kuint128max, kHex, /*width = */ 0,
+  CheckUint128Case({absl::Uint128Max(), kHex, /*width = */ 0,
                     "ffffffffffffffffffffffffffffffff"});
 }
 
diff --git a/absl/numeric/int128_test.cc b/absl/numeric/int128_test.cc
@@ -231,8 +231,6 @@ TEST(Uint128, AllTests) {
   EXPECT_EQ(two, -((-one) - 1));
   EXPECT_EQ(absl::Uint128Max(), -one);
   EXPECT_EQ(zero, -zero);
-
-  EXPECT_EQ(absl::Uint128Max(), absl::kuint128max);
 }
 
 TEST(Int128, RightShiftOfNegativeNumbers) {
diff --git a/absl/time/duration.cc b/absl/time/duration.cc
@@ -219,7 +219,7 @@ struct SafeMultiply {
                  ? static_cast<uint128>(Uint128Low64(a) * Uint128Low64(b))
                  : a * b;
     }
-    return b == 0 ? b : (a > kuint128max / b) ? kuint128max : a * b;
+    return b == 0 ? b : (a > Uint128Max() / b) ? Uint128Max() : a * b;
   }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -231,8 +231,6 @@ TEST(Uint128, AllTests) {`
`231`	`231`	`EXPECT_EQ(two, -((-one) - 1));`
`232`	`232`	`EXPECT_EQ(absl::Uint128Max(), -one);`
`233`	`233`	`EXPECT_EQ(zero, -zero);`
`234`		`-`
`235`		`- EXPECT_EQ(absl::Uint128Max(), absl::kuint128max);`
`236`	`234`	`}`
`237`	`235`
`238`	`236`	`TEST(Int128, RightShiftOfNegativeNumbers) {`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ struct SafeMultiply {`
`219`	`219`	`? static_cast<uint128>(Uint128Low64(a) * Uint128Low64(b))`
`220`	`220`	`: a * b;`
`221`	`221`	`}`
`222`		`- return b == 0 ? b : (a > kuint128max / b) ? kuint128max : a * b;`
	`222`	`+ return b == 0 ? b : (a > Uint128Max() / b) ? Uint128Max() : a * b;`
`223`	`223`	`}`
`224`	`224`	`};`
`225`	`225`