You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds meta to any templates created from this point forward, so we can easily distinguish between templates created the old way and new way.
Why?
This makes the migrate function more stable: if the active_templates option is ever removed, any new templates created will not suddenly become activated due to this migration, only the old templates will.
It gives us a bit more room to fix migrations in case of a revert of the whole feature.
How?
Adds the meta any time a template is created from now on. In the migration function, check that the templates do not have this meta.
To do: when you de-activate one of the old templates, ideally we should add the meta to them.
Idea: perhaps there is a way we can avoid the migration entirely: if a template doesn't have the inactive_by_default meta, then it should just be considered active regardless of the option. It makes the checks for activation a bit more complex though.
Testing Instructions
Create a new template. Delete the active_templates option. This new templates should not be activated due to the migration function.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in a24a6bf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds meta to any templates created from this point forward, so we can easily distinguish between templates created the old way and new way.
Why?
active_templates
option is ever removed, any new templates created will not suddenly become activated due to this migration, only the old templates will.How?
Adds the meta any time a template is created from now on. In the migration function, check that the templates do not have this meta.
To do: when you de-activate one of the old templates, ideally we should add the meta to them.
Idea: perhaps there is a way we can avoid the migration entirely: if a template doesn't have the
inactive_by_default
meta, then it should just be considered active regardless of the option. It makes the checks for activation a bit more complex though.Testing Instructions
Create a new template. Delete the
active_templates
option. This new templates should not be activated due to the migration function.Testing Instructions for Keyboard
Screenshots or screencast