You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing feedback from @justintadlock. When the user switches themes, any active templates that are associated with the previous theme should be ignored.
Why?
Currently templates are often heavily dependent on styles and patterns from the current theme.
How?
Whenever new templates are created, we already save information to the database that associates it with the current theme. Fixing the issue is just a matter of using that data:
On the front-end, check that the active templated set for a slug is associated with the current theme, otherwise ignore it.
In the site editor, also make sure the template is no longer marked as active. For now, I've opted to also disable the "activate" action. Users can still choose to duplicate the template, which will update the association, and maybe it available to activate. I've also added an extra field to indicate the lack of compatibility.
Please note: when you switched themes previously in WP, theme template edits would completely disappear.
Testing Instructions
Duplicate the Home template for 2025 (for example), make some changes, and activate it.
Switch to 2024. The Home page should now use the 2024 template, and the custom template should be inactive.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
ellatrix
changed the title
Template activation: lock templates to themes
Template activation: ignore templates not associated with active theme
Oct 2, 2025
Flaky tests detected in 0e3e18a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The reason will be displayed to describe this comment to others. Learn more.
After testing, this seems to work as I'd expect.
I created a custom single post template with Twenty Twenty-Five active and tested that it works. When I switched to a new theme, the custom template was automatically deactivated, allowing the new theme's single post template to take precedence. I could then edit my inactive custom template and make it active again.
[Type] BugAn existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #71735.
Addressing feedback from @justintadlock. When the user switches themes, any active templates that are associated with the previous theme should be ignored.
Why?
Currently templates are often heavily dependent on styles and patterns from the current theme.
How?
Whenever new templates are created, we already save information to the database that associates it with the current theme. Fixing the issue is just a matter of using that data:
Please note: when you switched themes previously in WP, theme template edits would completely disappear.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast