You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In trunk, when clicking the Edit contents button on an unsynced pattern, the Block Inspector becomes empty.
Why?
The issue is that after clicking the 'Edit contents' button, neither of the tabs (Settings or Styles) is selected. From the 'before' screenshot you can see neither tab has the underline indicating selection.
The Tabs component still considers the 'Content' tab as the selected one, even though clicking 'Edit contents' removes it.
How?
Use the Tabs component as a controlled component. When the list of tabs changes, an effect checks that the selected tab is still present. If it's no longer present, the code falls back to the first tab being the selected tab.
Testing Instructions
Turn on the Gutenberg > Experiment: contentOnly: make patterns contentOnly by default upon insertion
Go to the site editor
Open the sidebar inspector
Select a pattern that defaults to contentOnly (or insert a new pattern, most should work)
Click the Edit contents button
In trunk: Sidebar contents disappear
In this PR: The Settings tab content is shown
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Pushed a couple of extra commits. The effect from this PR was overriding the initialTabName config that the navigation block uses, so I've added an early return to make sure it doesn't happen. (resolves the failing e2e test).
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsynced[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71951
In trunk, when clicking the Edit contents button on an unsynced pattern, the Block Inspector becomes empty.
Why?
The issue is that after clicking the 'Edit contents' button, neither of the tabs (Settings or Styles) is selected. From the 'before' screenshot you can see neither tab has the underline indicating selection.
The
Tabs
component still considers the 'Content' tab as the selected one, even though clicking 'Edit contents' removes it.How?
Use the
Tabs
component as a controlled component. When the list oftabs
changes, an effect checks that the selected tab is still present. If it's no longer present, the code falls back to the first tab being the selected tab.Testing Instructions
In trunk: Sidebar contents disappear
In this PR: The Settings tab content is shown
Screenshots or screencast