You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occurred due to an optimization that was added. It assumed that if we'd just assigned a disabled mode to a parent, the disabled mode should automatically cascade and the child should also be disabled. However, that was incorrect, in contentOnly mode we often want a disabled parent to have a contentOnly child, the optimization was not allowing this.
Testing Instructions
Turn on Gutenberg -> experiments: When patterns are inserted, default to a simplified content only mode for editing pattern content.
Go to a page
Use the Show Template option to show the Zoom Out button (Header > Computer Icon > Show Template)
Insert or confirm there is a content only pattern
Select something within the content only pattern
Toggle the Zoom out button on/off
Expected: You should be able to select the content in the pattern
In trunk: You can't select the content in the pattern
Flaky tests detected in baaa9bc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsynced[Type] BugAn existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71908
How?
The bug occurred due to an optimization that was added. It assumed that if we'd just assigned a
disabled
mode to a parent, thedisabled
mode should automatically cascade and the child should also bedisabled
. However, that was incorrect, incontentOnly
mode we often want adisabled
parent to have acontentOnly
child, the optimization was not allowing this.Testing Instructions
Expected: You should be able to select the content in the pattern
In trunk: You can't select the content in the pattern