You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Utsav-Ladani! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
My explanation was unclear, but I think the p element should only be supported internally. In the past, there was discussion about whether the p tag should be supported in the UI, even in the Post Title block. As a result, it was limited to internal support due to accessibility concerns. See #30549 for more details.
Since the Post Type Label can also be a title, I think the UI should not be exposed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71831
In the
Post Type Label
block, allowing the use ofParagraph
for formatting with other heading tags and setting it as the default.Why?
Based on the comment on the issue introducing the "Post Type Label" block:
#71167 (comment)
Most layouts don't need the post type to be a heading. Therefore, adding the
Paragraph
level option and setting it as the default.How?
This PR is adding the
Paragraph
option to theChange Level
dropdown and setting default value oflevel
to0
for thePost Type Label
block variation.Testing Instructions
Post Type Label
block.Paragraph
.Note
Also ensure that it continues working with the existing
Post Type Label
block which was inserted with an older version.Testing Instructions for Keyboard
Screenshots or screencast