You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on #71308 to make blocks associated with comments more clear.
Why?
#71308 dispatches flashBlock action when the related comment is selected. Because flashBlock only highlights the block for a split second, it can be difficult to see the block associated with a comment, and you have to click the comment again to flash the block.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in 7ecacf5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up on #71308 to make blocks associated with comments more clear.
Why?
#71308 dispatches
flashBlock
action when the related comment is selected. Because flashBlock only highlights the block for a split second, it can be difficult to see the block associated with a comment, and you have to click the comment again to flash the block.How?
I realized we might be able to reuse the logic for associating list views with blocks. So in this PR, I'm introducing the following behaviors:
useDebounce
hook totoggleHighLight
to reduce the nastiness of the block when you move the mouse quickly.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
ffd90a3acc8826f7b731c6db5dd7d2da.mp4